Skip to content
reviewdog

Remove specs for old rails versions #8

Sign in to view logs

Remove specs for old rails versions

Remove specs for old rails versions #8

Triggered via push December 3, 2024 15:11
@codezcodez
pushed a54dd46
fix-specs
Status Success
Total duration 23s
Artifacts –

reviewdog.yml

on: push
runner / rubocop
13s
runner / rubocop
Fit to window
Zoom out
Zoom in

Annotations

46 errors and 6 warnings
[rubocop] Rakefile#L147: Rakefile#L147
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
[rubocop] lib/apartment.rb#L68: lib/apartment.rb#L68
[Correctable] Style/RedundantParentheses: Don't use parentheses around a logical expression.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L1: lib/apartment/active_record/postgres/schema_dumper.rb#L1
[Correctable] Style/FrozenStringLiteralComment: Missing frozen string literal comment.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L4: lib/apartment/active_record/postgres/schema_dumper.rb#L4
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L5: lib/apartment/active_record/postgres/schema_dumper.rb#L5
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L7: lib/apartment/active_record/postgres/schema_dumper.rb#L7
Style/Documentation: Missing top-level documentation comment for class ActiveRecord::ConnectionAdapters::PostgreSQL::SchemaDumper.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L7: lib/apartment/active_record/postgres/schema_dumper.rb#L7
[Correctable] Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L8: lib/apartment/active_record/postgres/schema_dumper.rb#L8
[Correctable] Style/Alias: Use alias instead of alias_method in a class body.
[rubocop] lib/apartment/adapters/sqlite3_adapter.rb#L43: lib/apartment/adapters/sqlite3_adapter.rb#L43
[Correctable] Style/SuperWithArgsParentheses: Use parentheses for super with arguments.
[rubocop] lib/apartment/elevators/host_hash.rb#L12: lib/apartment/elevators/host_hash.rb#L12
[Correctable] Style/SuperWithArgsParentheses: Use parentheses for super with arguments.
[rubocop] lib/apartment/log_subscriber.rb#L11: lib/apartment/log_subscriber.rb#L11
[Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
[rubocop] lib/apartment/log_subscriber.rb#L17: lib/apartment/log_subscriber.rb#L17
[Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
[rubocop] lib/apartment/log_subscriber.rb#L20: lib/apartment/log_subscriber.rb#L20
[Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
[rubocop] lib/apartment/log_subscriber.rb#L20: lib/apartment/log_subscriber.rb#L20
[Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
[rubocop] lib/apartment/migrator.rb#L7: lib/apartment/migrator.rb#L7
[Correctable] Style/ModuleFunction: Use module_function instead of extend self.
[rubocop] lib/apartment/migrator.rb#L45: lib/apartment/migrator.rb#L45
[Correctable] Layout/EmptyLinesAroundModuleBody: Extra empty line detected at module body end.
[rubocop] spec/dummy/config/initializers/backtrace_silencers.rb#L2: spec/dummy/config/initializers/backtrace_silencers.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy/config/initializers/inflections.rb#L2: spec/dummy/config/initializers/inflections.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy/config/initializers/mime_types.rb#L2: spec/dummy/config/initializers/mime_types.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy_engine/test/dummy/config/initializers/backtrace_silencers.rb#L2: spec/dummy_engine/test/dummy/config/initializers/backtrace_silencers.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy_engine/test/dummy/config/initializers/inflections.rb#L2: spec/dummy_engine/test/dummy/config/initializers/inflections.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy_engine/test/dummy/config/initializers/mime_types.rb#L2: spec/dummy_engine/test/dummy/config/initializers/mime_types.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/integration/apartment_rake_integration_spec.rb#L50: spec/integration/apartment_rake_integration_spec.rb#L50
[Correctable] RSpec/ScatteredLet: Group all let/let! blocks in the example group together.
[rubocop] Rakefile#L147: Rakefile#L147
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
[rubocop] lib/apartment.rb#L68: lib/apartment.rb#L68
[Correctable] Style/RedundantParentheses: Don't use parentheses around a logical expression.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L1: lib/apartment/active_record/postgres/schema_dumper.rb#L1
[Correctable] Style/FrozenStringLiteralComment: Missing frozen string literal comment.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L4: lib/apartment/active_record/postgres/schema_dumper.rb#L4
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L5: lib/apartment/active_record/postgres/schema_dumper.rb#L5
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L7: lib/apartment/active_record/postgres/schema_dumper.rb#L7
Style/Documentation: Missing top-level documentation comment for class ActiveRecord::ConnectionAdapters::PostgreSQL::SchemaDumper.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L7: lib/apartment/active_record/postgres/schema_dumper.rb#L7
[Correctable] Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
[rubocop] lib/apartment/active_record/postgres/schema_dumper.rb#L8: lib/apartment/active_record/postgres/schema_dumper.rb#L8
[Correctable] Style/Alias: Use alias instead of alias_method in a class body.
[rubocop] lib/apartment/adapters/sqlite3_adapter.rb#L43: lib/apartment/adapters/sqlite3_adapter.rb#L43
[Correctable] Style/SuperWithArgsParentheses: Use parentheses for super with arguments.
[rubocop] lib/apartment/elevators/host_hash.rb#L12: lib/apartment/elevators/host_hash.rb#L12
[Correctable] Style/SuperWithArgsParentheses: Use parentheses for super with arguments.
[rubocop] lib/apartment/log_subscriber.rb#L11: lib/apartment/log_subscriber.rb#L11
[Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
[rubocop] lib/apartment/log_subscriber.rb#L17: lib/apartment/log_subscriber.rb#L17
[Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
[rubocop] lib/apartment/log_subscriber.rb#L20: lib/apartment/log_subscriber.rb#L20
[Correctable] Style/SuperArguments: Call super without arguments and parentheses when the signature is identical.
[rubocop] lib/apartment/log_subscriber.rb#L20: lib/apartment/log_subscriber.rb#L20
[Correctable] Style/ArgumentsForwarding: Use anonymous block arguments forwarding (&).
[rubocop] lib/apartment/migrator.rb#L7: lib/apartment/migrator.rb#L7
[Correctable] Style/ModuleFunction: Use module_function instead of extend self.
[rubocop] lib/apartment/migrator.rb#L45: lib/apartment/migrator.rb#L45
[Correctable] Layout/EmptyLinesAroundModuleBody: Extra empty line detected at module body end.
[rubocop] spec/dummy/config/initializers/backtrace_silencers.rb#L2: spec/dummy/config/initializers/backtrace_silencers.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy/config/initializers/inflections.rb#L2: spec/dummy/config/initializers/inflections.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy/config/initializers/mime_types.rb#L2: spec/dummy/config/initializers/mime_types.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy_engine/test/dummy/config/initializers/backtrace_silencers.rb#L2: spec/dummy_engine/test/dummy/config/initializers/backtrace_silencers.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy_engine/test/dummy/config/initializers/inflections.rb#L2: spec/dummy_engine/test/dummy/config/initializers/inflections.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/dummy_engine/test/dummy/config/initializers/mime_types.rb#L2: spec/dummy_engine/test/dummy/config/initializers/mime_types.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.
[rubocop] spec/integration/apartment_rake_integration_spec.rb#L50: spec/integration/apartment_rake_integration_spec.rb#L50
[Correctable] RSpec/ScatteredLet: Group all let/let! blocks in the example group together.
[rubocop] spec/adapters/sqlite3_adapter_spec.rb#L28: spec/adapters/sqlite3_adapter_spec.rb#L28
Lint/NonAtomicFileOperation: Use atomic file operation method FileUtils.rm_f.
[rubocop] spec/adapters/sqlite3_adapter_spec.rb#L28: spec/adapters/sqlite3_adapter_spec.rb#L28
[Correctable] Lint/NonAtomicFileOperation: Remove unnecessary existence check File.exist?.
runner / rubocop
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
runner / rubocop
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
[rubocop] spec/adapters/sqlite3_adapter_spec.rb#L28: spec/adapters/sqlite3_adapter_spec.rb#L28
Lint/NonAtomicFileOperation: Use atomic file operation method FileUtils.rm_f.
[rubocop] spec/adapters/sqlite3_adapter_spec.rb#L28: spec/adapters/sqlite3_adapter_spec.rb#L28
[Correctable] Lint/NonAtomicFileOperation: Remove unnecessary existence check File.exist?.