#931: TODOs in UserAuthorizationService implementiert

puzzle · Aug 6, 2024 · 4f98384 · 4f98384
1 parent da13e29
commit 4f98384
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/backend/src/main/java/ch/puzzle/okr/service/authorization/UserAuthorizationService.java b/backend/src/main/java/ch/puzzle/okr/service/authorization/UserAuthorizationService.java
@@ -66,23 +66,22 @@ public List<User> createUsers(List<User> userList) {
     }
 
     public boolean isUserMemberOfTeams(long id) {
-        // TODO check Role
         List<UserTeam> userTeamList = userBusinessService.getUserById(id).getUserTeamList();
         return userTeamList != null && !userTeamList.isEmpty();
     }
 
     public boolean isUserOwnerOfKeyResults(long id) {
-        // TODO check Role
         return keyResultBusinessService.isUserOwnerOfKeyResults(id);
     }
 
     public void deleteEntityById(long id) {
-        // TODO check Role
+        AuthorizationService.checkRoleWriteAndReadAll(authorizationService.updateOrAddAuthorizationUser(),
+                OkrResponseStatusException.of(ErrorKey.NOT_AUTHORIZED_TO_DELETE, USER));
+
         userBusinessService.deleteEntityById(id);
     }
 
     public UserOkrDataDto getUserOkrData(long id) {
-        // TODO check Role
         List<KeyResult> keyResultsOwnedByUser = keyResultBusinessService.getKeyResultsOwnedByUser(id);
         return new UserOkrDataMapper().toDto(keyResultsOwnedByUser);
     }