Skip to content

Commit

Permalink
run formatter and turn prefer standalone rule off
Browse files Browse the repository at this point in the history
  • Loading branch information
nevio18324 committed Dec 24, 2024
1 parent 1ee0283 commit 5bab328
Show file tree
Hide file tree
Showing 55 changed files with 63 additions and 62 deletions.
2 changes: 2 additions & 0 deletions frontend/eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ export default tsEslint.config(
'@stylistic/function-paren-newline': ['error', { minItems: 4 }],
'@stylistic/space-before-function-paren': ['error', 'never'],

// Off because angular our files are not standalone
'@angular-eslint/prefer-standalone': 'off',
'@angular-eslint/directive-selector': [
'error',
{
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { DomSanitizer } from '@angular/platform-browser';
templateUrl: './app.component.html',
styleUrls: ['./app.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class AppComponent {
readonly PATH_PREFIX = '../assets/icons/';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { DialogService } from '../../services/dialog.service';
selector: 'app-action-plan',
templateUrl: './action-plan.component.html',
styleUrls: ['./action-plan.component.scss'],
standalone: false,
standalone: false
})
export class ActionPlanComponent {
@Input() control: BehaviorSubject<Action[] | null> = new BehaviorSubject<Action[] | null>([]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { DEFAULT_HEADER_HEIGHT_PX, PUZZLE_TOP_BAR_HEIGHT } from '../../shared/co
templateUrl: './application-banner.component.html',
styleUrls: ['./application-banner.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class ApplicationBannerComponent implements AfterViewInit, OnDestroy {
@ViewChild('okrBanner') okrBanner!: ElementRef;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { getFullNameFromUser } from '../../shared/types/model/User';
templateUrl: './application-top-bar.component.html',
styleUrls: ['./application-top-bar.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class ApplicationTopBarComponent implements OnInit, OnDestroy {
userFullName = '';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { CheckInOrdinalMin } from '../../shared/types/model/CheckInOrdinalMin';
@Component({
selector: 'app-check-in-history-dialog',
templateUrl: './check-in-history-dialog.component.html',
standalone: false,
standalone: false
})
export class CheckInHistoryDialogComponent implements OnInit {
keyResult!: KeyResult;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { CheckInMetricMin } from '../../../shared/types/model/CheckInMetricMin';
templateUrl: './check-in-form-metric.component.html',
styleUrls: ['./check-in-form-metric.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class CheckInFormMetricComponent implements OnInit {
@Input()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@ import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';

@Directive({
selector: '[metricCheckIn]',
providers: [
{
provide: NG_VALUE_ACCESSOR,
useExisting: forwardRef(() => MetricCheckInDirective),
multi: true,
},
],
standalone: false,
providers: [{
provide: NG_VALUE_ACCESSOR,
useExisting: forwardRef(() => MetricCheckInDirective),
multi: true
}],
standalone: false
})
export class MetricCheckInDirective implements ControlValueAccessor {
private onChange: (value: number | null) => void = () => {};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { CheckInMin } from '../../../shared/types/model/CheckInMin';
selector: 'app-check-in-form-ordinal',
templateUrl: './check-in-form-ordinal.component.html',
styleUrls: ['./check-in-form-ordinal.component.scss'],
standalone: false,
standalone: false
})
export class CheckInFormOrdinalComponent {
@Input()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { CheckInOrdinalMin } from '../../../shared/types/model/CheckInOrdinalMin
templateUrl: './check-in-form.component.html',
styleUrls: ['./check-in-form.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class CheckInFormComponent implements OnInit {
keyResult: KeyResult;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { CheckInMin } from '../../shared/types/model/CheckInMin';
templateUrl: './confidence.component.html',
styleUrls: ['./confidence.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class ConfidenceComponent implements OnChanges {
min = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { TranslateService } from '@ngx-translate/core';
templateUrl: './key-result-form.component.html',
styleUrls: ['./key-result-form.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class KeyResultFormComponent implements OnInit, OnDestroy {
users$!: Observable<User[]>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { KeyResultOrdinalMin } from '../../shared/types/model/KeyResultOrdinalMi
templateUrl: './keyresult-detail.component.html',
styleUrls: ['./keyresult-detail.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class KeyresultDetailComponent implements OnInit, OnDestroy {
@Input() keyResultId!: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { DialogService } from '../../services/dialog.service';
selector: 'app-keyresult-dialog',
templateUrl: './keyresult-dialog.component.html',
styleUrls: ['./keyresult-dialog.component.scss'],
standalone: false,
standalone: false
})
export class KeyresultDialogComponent {
keyResultForm = new FormGroup({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { TranslateService } from '@ngx-translate/core';
selector: 'app-keyresult-type',
templateUrl: './keyresult-type.component.html',
styleUrls: ['./keyresult-type.component.scss'],
standalone: false,
standalone: false
})
export class KeyresultTypeComponent implements OnInit {
@Input() keyResultForm!: FormGroup;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { KeyResultOrdinalMin } from '../../shared/types/model/KeyResultOrdinalMi
templateUrl: './keyresult.component.html',
styleUrls: ['./keyresult.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class KeyresultComponent {
@Input() keyResult!: KeyresultMin;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { DialogService } from '../../services/dialog.service';
templateUrl: './objective-detail.component.html',
styleUrl: 'objective-detail.component.scss',
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class ObjectiveDetailComponent implements OnInit {
objectiveId!: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { debounceTime, map, Subject } from 'rxjs';
templateUrl: './objective-filter.component.html',
styleUrls: ['./objective-filter.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class ObjectiveFilterComponent implements OnInit {
refresh = new Subject<void>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { MatMenuTrigger } from '@angular/material/menu';
selector: 'app-objective-column',
templateUrl: './objective.component.html',
styleUrls: ['./objective.component.scss'],
standalone: false,
standalone: false
})
export class ObjectiveComponent {
@Input() isWritable!: boolean;
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/components/overview/overview.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { ConfigService } from '../../services/config.service';
templateUrl: './overview.component.html',
styleUrls: ['./overview.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class OverviewComponent implements OnInit, OnDestroy {
overviewEntities$: Subject<OverviewEntity[]> = new Subject<OverviewEntity[]>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { getValueFromQuery } from '../../shared/common';
selector: 'app-quarter-filter',
templateUrl: './quarter-filter.component.html',
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class QuarterFilterComponent implements OnInit {
quarters: BehaviorSubject<Quarter[]> = new BehaviorSubject<Quarter[]>([]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { BreakpointObserver } from '@angular/cdk/layout';
templateUrl: './team-filter.component.html',
styleUrls: ['./team-filter.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class TeamFilterComponent implements OnInit, OnDestroy {
teams$: BehaviorSubject<Team[]> = new BehaviorSubject<Team[]>([]);
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/components/team/team.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { BehaviorSubject, first } from 'rxjs';
templateUrl: './team.component.html',
styleUrls: ['./team.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class TeamComponent {
@Input({ required: true })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Observable, of } from 'rxjs';
selector: 'app-dialog-template-core',
templateUrl: './dialog-template-core.component.html',
styleUrl: './dialog-template-core.component.scss',
standalone: false,
standalone: false
})
export class DialogTemplateCoreComponent {
@Input() observable: Observable<any> = of({});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { map, Observable } from 'rxjs';
selector: 'app-okr-tangram',
templateUrl: 'okr-tangram.component.html',
styleUrl: 'okr-tangram.component.scss',
standalone: false,
standalone: false
})
export class OkrTangramComponent {
private readonly DEFAULT_TRIANGLE_SRC = 'assets/images/empty.svg';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Component, Input } from '@angular/core';
selector: 'app-puzzle-icon-button',
templateUrl: './puzzle-icon-button.component.html',
styleUrl: './puzzle-icon-button.component.scss',
standalone: false,
standalone: false
})
export class PuzzleIconButtonComponent {
@Input({ required: true })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Component, Input } from '@angular/core';
@Component({
selector: 'app-puzzle-icon',
templateUrl: './puzzle-icon.component.html',
standalone: false,
standalone: false
})
export class PuzzleIconComponent {
@Input({ required: true })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { CheckInOrdinalMin } from '../../types/model/CheckInOrdinalMin';
templateUrl: './scoring.component.html',
styleUrls: ['./scoring.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class ScoringComponent implements OnInit, AfterViewInit, OnChanges {
@Input() keyResult!: KeyResultOrdinalMin | KeyResultMetricMin;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Component, Input } from '@angular/core';
selector: 'app-spinner',
templateUrl: './spinner.component.html',
styleUrl: './spinner.component.scss',
standalone: false,
standalone: false
})
export class SpinnerComponent {
@Input({ required: false })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { TranslateService } from '@ngx-translate/core';
selector: 'app-complete-dialog',
templateUrl: './complete-dialog.component.html',
styleUrls: ['./complete-dialog.component.scss'],
standalone: false,
standalone: false
})
export class CompleteDialogComponent {
completeForm = new FormGroup({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { ButtonState } from '../../types/enums/ButtonState';
selector: 'app-confirm-dialog',
templateUrl: './confirm-dialog.component.html',
styleUrls: ['./confirm-dialog.component.scss'],
standalone: false,
standalone: false
})
export class ConfirmDialogComponent implements OnInit {
dialogTitle = '';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { formInputCheck } from '../../common';
@Component({
selector: 'app-example-dialog',
templateUrl: './example-dialog.component.html',
standalone: false,
standalone: false
})
export class ExampleDialogComponent {
hobbies = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { KeyResultDTO } from '../../types/DTOs/KeyResultDTO';
templateUrl: './objective-form.component.html',
styleUrls: ['./objective-form.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class ObjectiveFormComponent implements OnInit, OnDestroy {
objectiveForm = new FormGroup({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Pipe, PipeTransform } from '@angular/core';

@Pipe({
name: 'unitTransformation',
standalone: false,
standalone: false
})
export class UnitTransformationPipe implements PipeTransform {
transform(value: number, label: string): string {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/shared/sidepanel/sidepanel.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { ConnectedPosition } from '@angular/cdk/overlay'; // ESM
templateUrl: './sidepanel.component.html',
styleUrls: ['./sidepanel.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false,
standalone: false
})
export class SidepanelComponent implements OnInit, AfterContentInit, OnDestroy {
leaveKeys = ['Escape'];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { Router } from '@angular/router';
selector: 'app-add-edit-team-dialog',
templateUrl: './add-edit-team-dialog.component.html',
styleUrls: ['./add-edit-team-dialog.component.scss'],
standalone: false,
standalone: false
})
export class AddEditTeamDialog implements OnInit {
teamForm = new FormGroup({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface AddMemberToTeamDialogComponentData {
selector: 'app-add-member-to-team-dialog',
templateUrl: './add-member-to-team-dialog.component.html',
styleUrl: './add-member-to-team-dialog.component.scss',
standalone: false,
standalone: false
})
export class AddMemberToTeamDialogComponent implements OnInit, OnDestroy {
@ViewChild(MatTable) table!: MatTable<User[]>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { UserTeam } from '../../shared/types/model/UserTeam';
selector: 'app-add-user-team',
templateUrl: './add-user-team.component.html',
styleUrl: './add-user-team.component.scss',
standalone: false,
standalone: false
})
export class AddUserTeamComponent implements OnInit, OnDestroy {
@Output()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { UserOkrData } from '../../shared/types/model/UserOkrData';
selector: 'app-delete-user',
templateUrl: './delete-user.component.html',
styleUrl: './delete-user.component.scss',
standalone: false,
standalone: false
})
export class DeleteUserComponent implements OnInit, OnDestroy {
@Input({ required: true }) user!: User;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { TeamService } from '../../services/team.service';
selector: 'app-edit-okr-champion',
templateUrl: './edit-okr-champion.component.html',
styleUrl: './edit-okr-champion.component.scss',
standalone: false,
standalone: false
})
export class EditOkrChampionComponent {
@Input({ required: true }) user!: User;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
selector: 'app-invite-user-dialog',
templateUrl: './invite-user-dialog.component.html',
styleUrl: './invite-user-dialog.component.scss',
standalone: false,
standalone: false
})
export class InviteUserDialogComponent {
form: FormArray<FormGroup<NewUserForm<FormControl>>>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { DialogService } from '../../services/dialog.service';
selector: 'app-member-detail',
templateUrl: './member-detail.component.html',
styleUrl: './member-detail.component.scss',
standalone: false,
standalone: false
})
export class MemberDetailComponent implements OnInit, OnDestroy {
@ViewChild(MatTable) table!: MatTable<User[]>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { getRouteToUserDetails } from '../../../shared/routeUtils';
selector: 'app-member-list-mobile',
templateUrl: './member-list-mobile.component.html',
styleUrl: './member-list-mobile.component.scss',
standalone: false,
standalone: false
})
export class MemberListMobileComponent implements OnInit {
@Input({ required: true }) dataSource!: MatTableDataSource<UserTableEntry>;
Expand Down
Loading

0 comments on commit 5bab328

Please sign in to comment.