Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Members einladen: Delete ermöglichen #931

Closed
janikEndtner opened this issue May 30, 2024 · 3 comments · Fixed by #1173
Closed

Members einladen: Delete ermöglichen #931

janikEndtner opened this issue May 30, 2024 · 3 comments · Fixed by #1173
Assignees
@clean-coder
Labels
Special A Ticket which is reserved and should not be taken
Milestone
Feature Requests BBT

Comments

@janikEndtner
Copy link
Collaborator

janikEndtner commented May 30, 2024 •
edited
Loading

Als OKR Champion möchte ich Members, die ich eingeladen habe, wieder löschen und allenfalls updaten können, so dass ich meine Aktion rückgängig machen kann, wenn ich fälschlicherweise einen Member eingeladen habe.

AK:

  • Im Sidebar Component gibt es einen Button "Member löschen" der nur für den OKR Champion sichtbar ist

Image

  • Beim Klick auf diesen Button soll ein Dialog erscheinen "Soll dieser Member wirklich gelöscht werden?"
  • Falls bestätigt wird, wird der Member aus der Datenbank gelöscht.
  • Dies kann nur gemacht werden, falls der User kein Owner eines KeyResults ist
  • Falls doch, wird eine entsprechende Fehlermeldung ausgegeben: "Der Member kann nicht gelöscht werden, weil er Owner eines KeyResults ist ([KEY_RESULT_TITLE], [OBJECTIVE_TITLE])
@janikEndtner janikEndtner added this to the Mandantenfähigkeit milestone May 30, 2024
@janikEndtner janikEndtner added the Special A Ticket which is reserved and should not be taken label Jul 21, 2024
@janikEndtner janikEndtner changed the title Members einladen: Delete und Update ermöglichen Members einladen: Delete ermöglichen Jul 22, 2024
@janikEndtner janikEndtner added Special A Ticket which is reserved and should not be taken and removed Special A Ticket which is reserved and should not be taken labels Jul 22, 2024
clean-coder added a commit that referenced this issue Jul 26, 2024
@clean-coder
#931: new component DeleteUserComponent
7b82381
clean-coder added a commit that referenced this issue Jul 26, 2024
@clean-coder
#931: new server calls for deleting a user and checking if user is ow…
0bf84f9 
…ner of keyresults
clean-coder added a commit that referenced this issue Jul 26, 2024
@clean-coder
#931: use DeleteUserComponent
57a5904
clean-coder added a commit that referenced this issue Jul 26, 2024
@clean-coder
#931: rest calls for delete user and checking of user owner of keyres…
8126efb 
…ults
clean-coder added a commit that referenced this issue Jul 29, 2024
@clean-coder
#931: show confirm dialog before deleting User
b057fa9
clean-coder added a commit that referenced this issue Jul 29, 2024
@clean-coder
#931: use CancelDialog instead of alert()
3e49de2
clean-coder added a commit that referenced this issue Jul 29, 2024
@clean-coder
#931: create alert dialog component (dialog with only a close button)
30c378b
clean-coder added a commit that referenced this issue Jul 29, 2024
@clean-coder
#931: use AlertDialogComponent instead of CancelDialogComponent
e2dbb27
clean-coder added a commit that referenced this issue Jul 29, 2024
@clean-coder
#931: cleanup + calculate isUserMemberOfTeams on-the-fly (no longer c…
28c1c52 
…ached)
@clean-coder
Copy link
Collaborator

clean-coder commented Jul 29, 2024 •
edited
Loading

Es gibt einen Branch https://github.com/puzzle/okr/tree/feature/931_delete_member. Dort wird das UI (Angular) erweitert für das Löschen von Members. Dann kann man sich in dieser Story #931 und #846 auf die Java Implementierung im backend konzentrieren.

clean-coder added a commit that referenced this issue Jul 29, 2024
@clean-coder
#931: show "remove member" button only if the okrUser has role OkrCha…
818e3aa 
…mpion
clean-coder added a commit that referenced this issue Jul 29, 2024
@clean-coder
#931: fix MemberDetailComponent test
5973530
@clean-coder
Copy link
Collaborator

clean-coder commented Jul 29, 2024 •
edited
Loading

Status: https://github.com/puzzle/okr/tree/feature/931_delete_member

Frontend

  • ✓ delete-user.component (löschen Member + backendCall + validation Rules)
  • ✓ alert-dialog.component (MatDialog nur mit einem Button "Schliessen" und Support für Liste of Details)
  • ✓ Anzeige "Member löschen" Button/Link, nur wenn OkrUser die Rolle OkrChampion hat
  • ✓ Anzeige, in welchen Teams der user ist
  • ✓ Anzeige, in welchen OKRs/KeyResults der user owner ist
  • x Client jest Tests
  • x Client Cypress Tests

Backend

  • 2 neue Rest Endpoints
    • ✓ Support für Frontend Validations: getUserOkrData()
    • ✓ Löschen eines Users: deleteUserById()
  • ✓ Tests für Löschen eines Users (UserController | UserBusinessService | UserPersistenceService Tests)
  • TODOs:
    • x Ausbau Rest EndPoint für "check if user is owner of KeyResult" (da nicht mehr verwendet)
    • x Authorization Checking implementieren (für deleteUserById() und getUserOkrData())
    • x jUnit Tests für getUserOkrData()

clean-coder added a commit that referenced this issue Jul 30, 2024
@clean-coder
#931: UserController test for delete user by id
687b5d1
clean-coder added a commit that referenced this issue Jul 30, 2024
@clean-coder
#931: UserBusinessService test for delete user by id
c36b2db
clean-coder added a commit that referenced this issue Jul 30, 2024
@clean-coder
#931: UserPersistenceService test for delete user by id
f55e7bb
clean-coder added a commit that referenced this issue Jul 30, 2024
@clean-coder
#931: in dialog, show team information of the user
bb1ded9
clean-coder added a commit that referenced this issue Jul 30, 2024
@clean-coder
#931: fix wording error
9e73b6d
clean-coder added a commit that referenced this issue Jul 31, 2024
@clean-coder
#931: support for dialogDetails in DeleteUserComponent
6eda254
clean-coder added a commit that referenced this issue Jul 31, 2024
@clean-coder
#931: load (and display) userOkrData instead of only a flag, if isUse…
3051e4b 
…rOwnerOfKeyResults
clean-coder added a commit that referenced this issue Jul 31, 2024
@clean-coder
#931: new endpoint getUserOkrData()
4bbc2db
clean-coder added a commit that referenced this issue Jul 31, 2024
@clean-coder
#931: added test for AlertDialogComponent
3436d1d
clean-coder added a commit that referenced this issue Jul 31, 2024
@clean-coder
#931: additional test for getUserOkrData() and deleteUser() in UserSe…
fc92272 
…rvice
clean-coder added a commit that referenced this issue Aug 5, 2024
@clean-coder
#931: test for DeleteUserComponent
882b132
clean-coder added a commit that referenced this issue Aug 6, 2024
@clean-coder
#931: new Rest EndPoint isUserMemberOfTeams()
43c86bc
clean-coder added a commit that referenced this issue Aug 6, 2024
@clean-coder
#931: support for isUserMemberOfTeams() Rest EndPoint in the client
6aa66a4
clean-coder added a commit that referenced this issue Aug 6, 2024
@clean-coder
#931: calculate userIsMemberOfTeams state whenever currentTeams changes
da13e29
clean-coder added a commit that referenced this issue Aug 7, 2024
@clean-coder
#931: TODOs in UserAuthorizationService implementiert
4f98384
clean-coder added a commit that referenced this issue Aug 7, 2024
@clean-coder
#931: tests for deleteUser()
a084700
clean-coder added a commit that referenced this issue Aug 7, 2024
@clean-coder
#931: cleanup DeleteUserComponent tests
8421d88
clean-coder added a commit that referenced this issue Aug 7, 2024
@clean-coder
#931: cleanup DeleteUserComponent
c9c7676
clean-coder added a commit that referenced this issue Aug 7, 2024
@clean-coder
#931: cleanup - removed unused RestEndPoint "iskeyresultowner"
3606bb3
@clean-coder clean-coder self-assigned this Aug 7, 2024
@clean-coder clean-coder mentioned this issue Aug 8, 2024
Closed
@clean-coder
Copy link
Collaborator

clean-coder commented Oct 22, 2024 •
edited
Loading

Habe den aktuellen Stand der Entwicklung dieses Features auf einen neuen Branch (gezogen von dev) geschoben:
https://github.com/puzzle/okr/tree/refs/heads/feature/931_delete_member_dev_branch

Der alte Branch https://github.com/puzzle/okr/tree/feature/931_delete_member wurde von multitenant_main gezogen und wird nicht mehr verwendet.

@clean-coder clean-coder linked a pull request Nov 19, 2024 that will close this issue
Feature/931 delete member dev branch v2 #1173
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clean-coder clean-coder

Labels
Special A Ticket which is reserved and should not be taken
Projects
None yet
Milestone
Feature Requests BBT
Development

Successfully merging a pull request may close this issue.

Feature/931 delete member dev branch v2 puzzle/okr
3 participants
@clean-coder @janikEndtner @peggimann