Bug/1143 aktuell on current quarter #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcinay055679
force-pushed
the
bug/1143-aktuell-on-current-quarter
branch
from
8ef4529 to
aafa610
Compare
2 tasks
peggimann
approved these changes
Nov 15, 2024
peggimann
approved these changes
Nov 15, 2024
* jar is now debuggable * rename folder * add a Observable that triggers a refresh when called * add destroy observable to stop subscription of reloadKeySubject * add tests to observables --------- Co-authored-by: Yanick Minder <[email protected]>
* add jar debug dev tools only on profile * refactor dialog calls with config by introducing a service * convert all confirmation dialog texts to i18n texts * use refactored confirmation component * fix string and use interface for confirm dialog data * Update title of delete confirmation * clean up dialog service * refactor frontend tests related to dialogService * display correct dialog in objective * fix objective release dialog * refactor dialog responsiveness * clean up dialog service * remove backend/pom.xml from branch * update translations and fix release dialog * update dialog.service.ts
* add auto data-migration * jar is now debuggable * add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * complete auto restart of container * rename intelij config and change log level of spring to debug in staging config * rename folder * update docker compose file * use external profile to disable formatter * clean up * add jar debug dev tools only on profile * add api endpoint * use api to get current quarter * convert quarter to a class instead of an interface * use class syntax * update specs to use the class syntax for quarters * mock new class function in test * add integratin test for current quarter endpoint * fix default quarter for new objective selection * use v2 for quarter url and update tests accoridingly * change merhod to fakeAsync * try to override provider mid test * Dispatch change instead of input event in onSubmit create test and get element by test id instead of id * Remove duplicate profile in pom * Update swagger annotations of get current quarter and fix usage of wrong implementation class for get current quarters * Remove unused import in common.ts * add dependency for hot reload in again * [FM] Automated formating frontend * readd local debug run config --------- Co-authored-by: Miguel Lehmann <[email protected]> Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: GitHub Actions <[email protected]>
* fix history * fix hist
* add jar debug dev tools only on profile * change log levels * try to fix autorestart of spring * rename intelij config and change log level of spring to debug in staging config * rename folder * use external profile to disable formatter * remove backend/pom.xml from branch * refactor styles of dialogs * remove useless tabindex * refactor styling of dialog-content and dialog-actions * refactor dialog header * clean up * fix invite members test * change default width of dialog * set cypress viewport * remove it.only from cy tests * use diffrent classes for default and small dialogs * remove useless config * clean up styling * remove scroll-shaddow * change height sizing strategie * refactor styling of keyresult edit component * introduce dialog-template-core-component * create base template for dialogs * align close button * comment in dialog component * fix scrolling of dialog * refactor kr-type-form * finish styling of kr-type select * fix scrolling by setting height of action buttons * clean up dialog content size * clean up styles.scss * refactor styles * refactor styles of generic component * move core component to shared module * fix design because of scrollbar * change keyresult type tabs to butotns * delete cancel dialog and refactor related files * refactor confirm dialog component to use template dialog core * refactor styling * refactor style of okr-label * refactor example dialog * refactor objective form component to use template dialog core * refactor objective form dialog * refactor dialog width * refactor keyresult component * fix responsive dialog * refactor objective complete dialog * clean up * refactor objective form component * minder out * fix objective form component * use priority to fetch logos * refactor dialog history compoennt * add spinner to dialog core * refactor dialog history component * refactor check-in componentn * refactor metric check in component * clean up keyresult dialog * clean up * fix kr type component * finish dialog refactoring * remove header component * refactor css classes * refactor styling * insert okr-form-label-input-container * fix dialog service tests * fix jest of objective form compoennt * fix tests of keyresult form * fix pom * fix tests of add-edit team dialog * fix tests keyresult-dialog tests * fix tests of complete dialog * fix jest tests * readd cancel button for check-in create * fix check-in e2e tests * fix e2e tests * remove only from cypress tests * fix teammanagement e2e test * fix duplicate scorring * clean up check-in tests * fix objective duplicate tests * clean up * clean up styles * create a dialog-data-show class * fix check in metric * fix keyresult type * clean up * implement todo --------- Co-authored-by: peggimann <[email protected]>
* Add permanent teamverwaltung button and make logo route to / * Make router links leading to homepage preserve query params * Change tag around logo from span to a * Add e2e tests that test if route is preserved --------- Co-authored-by: Jannik Pulfer <[email protected]> Co-authored-by: GitHub Actions <[email protected]>
* Fix/fix git history (#1125) * fix history * fix hist * jar is now debuggable * add jar debug dev tools only on profile * rename intelij config and change log level of spring to debug in staging config * rename folder * update docker compose file * use external profile to disable formatter * clean up * refactor dialog calls with config by introducing a service * refactor frontend tests related to dialogService * remove backend/pom.xml from branch * introduce new objective menu action service to simplify dialog creation of dialog actions * refactor objective * reimplement generic menu * use pipe with map to generate menu entries * introduce afterAction property * add ObjectiveAfterActionFactory * introduce objectiveMenuAction file * refactor objective status tooltip * clean up objective menu action service * rename objective actions file * Try to fix frontend unit tests * restore staging.properties * fix angular build * place functions in related files instead of common.ts * restore angular config files * fix action service tests * add test for actions service * clean up * display correct options for draft and use replay subject * fix check-in tests * fix objective backlog tests * fix objective e2e tests * fix tabbing tests * fix tabbing tests * schtibitz e2e strategy from pulfer * remove console.log * restore focus * restore old frontend-test-action * clean pup * remove application.staging from pr * clean up tests of objective * fix e2e tests * check for focues of threedot menu after dialog closes --------- Co-authored-by: Manuel <[email protected]>
* jar is now debuggable * rename intelij config and change log level of spring to debug in staging config * Fix bug with double label in check in history * delete unused pipe and edit the CHF output * edit e2e and frontend tests to work with the new format * remove lable pipe in dialog * add second pipe back in and edit to suffix * fix tests and refactor value pipe * fix spec tests for pipes * fix e2e tests * remove space before percent * fix unit-lable spec and e2e tests * fix spaceing of percent in tests * add testId --------- Co-authored-by: Yanick Minder <[email protected]> Co-authored-by: Lias Kleisa <[email protected]>
* Implement html structure and fix tests * Shorten logic in component * Remove unwanted styling that broke every dialog * Add styling to headings and fix obvious mistakes * Fix font size in banner and alignment of stretch star * Fix e2e test * Remove files that do not belong to my PR
kcinay055679
force-pushed
the
bug/1143-aktuell-on-current-quarter
branch
from
200b35d to
d9e942e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.