Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualize environment #1208

Merged
merged 37 commits into from
Dec 13, 2024
Merged

visualize environment #1208

merged 37 commits into from
Dec 13, 2024

Conversation

nevio18324
Copy link
Collaborator

…ng environment

@nevio18324 nevio18324 changed the title make topbar background color of staging violet to visualize its stagi… visualize environment Nov 25, 2024
@nevio18324 nevio18324 linked an issue Nov 25, 2024 that may be closed by this pull request
Staging Visuell #1204
Closed
2 tasks
@nevio18324 nevio18324 force-pushed the feature/1204-staging-visual branch from b2de332 to 0be91dd Compare December 2, 2024 11:49
@nevio18324 nevio18324 marked this pull request as ready for review December 2, 2024 14:01
RandomTannenbaum
RandomTannenbaum previously approved these changes Dec 2, 2024
View reviewed changes
frontend/src/app/components/team/team.component.ts Outdated Show resolved Hide resolved
frontend/src/style/styles.scss Outdated Show resolved Hide resolved
@RandomTannenbaum RandomTannenbaum dismissed their stale review December 2, 2024 14:37

Accidentally approved

@peggimann peggimann force-pushed the feature/1204-staging-visual branch from 25be011 to cd03fa0 Compare December 4, 2024 08:07
peggimann
peggimann requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@peggimann peggimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty severe bug for prod see screenshot.
visualization_add_objective_button

@peggimann peggimann closed this Dec 4, 2024
@peggimann peggimann reopened this Dec 4, 2024
MasterEvarior
MasterEvarior requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 👍

frontend/src/app/components/team/team.component.ts Outdated Show resolved Hide resolved
frontend/src/app/components/team/team.component.ts Show resolved Hide resolved
MasterEvarior
MasterEvarior previously requested changes Dec 5, 2024
View reviewed changes
frontend/src/app/components/team/team.component.html Outdated Show resolved Hide resolved
frontend/src/app/components/team/team.component.ts Outdated Show resolved Hide resolved
@RandomTannenbaum RandomTannenbaum force-pushed the feature/1204-staging-visual branch from e7a1a30 to 2142f4e Compare December 6, 2024 13:43
peggimann
peggimann previously requested changes Dec 11, 2024
View reviewed changes
backend/src/main/resources/application-demo.properties Outdated Show resolved Hide resolved
frontend/src/app/components/team/team.component.ts Outdated Show resolved Hide resolved
@nevio18324 @RandomTannenbaum
make topbar background color of staging violet to visualize its stagi…
fbc517e 
…ng environment
@nevio18324 @RandomTannenbaum
add new okr demo logo
a9c54e3
@nevio18324 @RandomTannenbaum
change styling of logo to fit okr demo logo
be26796
@nevio18324 @RandomTannenbaum
create new customstyles so background color of overview is changeable
4728320
@nevio18324 @RandomTannenbaum
change overviewBg to an css root variable so its changeable during ru…
4d86829 
…ntime
@nevio18324 @RandomTannenbaum
add two new customstyles for team title and add objective so they sta…
91b6b6c 
…y visible when using demo environment
@nevio18324 @RandomTannenbaum
add new addlogo for demo environment
22763ca
@nevio18324 @RandomTannenbaum
refactor extraction of customstyles in backend and add a new property…
5f78848 
… for new-icon
@nevio18324 @RandomTannenbaum
change extraction of add-objective-icon to be more generic
3e242e2
@nevio18324 @RandomTannenbaum
change naming and add white-outline when hovering add objective button
85a81a0
@nevio18324 @RandomTannenbaum
clean up getCustomCssStyles method and write comment
09c73be
@nevio18324 @RandomTannenbaum
revert changes done to TenantClientCustomizationProvider because it i…
cc9a822 
…sn't part of this PR and would have cost to much time
@RandomTannenbaum RandomTannenbaum force-pushed the feature/1204-staging-visual branch from 9fdc4e1 to 9211cfd Compare December 11, 2024 08:24
@RandomTannenbaum RandomTannenbaum marked this pull request as draft December 11, 2024 09:41
ManuelMoeri
ManuelMoeri requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@ManuelMoeri ManuelMoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to resolve the conversations from before aswell

.run/OkrApplication-Dev.run.xml Outdated Show resolved Hide resolved
backend/src/main/resources/application-demo.properties Outdated Show resolved Hide resolved
backend/src/main/resources/application-demo.properties Show resolved Hide resolved
backend/src/main/resources/application-dev.properties Outdated Show resolved Hide resolved
frontend/src/app/components/team/team.component.html Show resolved Hide resolved
ManuelMoeri
ManuelMoeri approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@ManuelMoeri ManuelMoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nevio18324 nevio18324 dismissed peggimann’s stale review December 12, 2024 14:37

changes were made

@nevio18324 nevio18324 marked this pull request as ready for review December 12, 2024 14:37
MasterEvarior
MasterEvarior approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on demo and staging 👍

@MasterEvarior MasterEvarior merged commit c0a6172 into main Dec 13, 2024
18 checks passed
@MasterEvarior MasterEvarior deleted the feature/1204-staging-visual branch December 13, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelMoeri ManuelMoeri ManuelMoeri approved these changes

@MasterEvarior MasterEvarior MasterEvarior approved these changes

@peggimann peggimann peggimann left review comments

@RandomTannenbaum RandomTannenbaum RandomTannenbaum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Staging Visuell
5 participants
@nevio18324 @MasterEvarior @RandomTannenbaum @ManuelMoeri @peggimann