Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/614 duplicate selected keyresults #1216

Merged
merged 36 commits into from
Dec 13, 2024
Merged

Feature/614 duplicate selected keyresults #1216

merged 36 commits into from
Dec 13, 2024

Conversation

nevio18324
Copy link
Collaborator

No description provided.

@ManuelMoeri ManuelMoeri force-pushed the feature/614-duplicate-selected-keyresults branch from 56b55bd to 7daf331 Compare November 27, 2024 09:41
@ManuelMoeri ManuelMoeri linked an issue Nov 27, 2024 that may be closed by this pull request
Keyresults Duplizieren #614
Closed
10 tasks
@ManuelMoeri ManuelMoeri force-pushed the feature/614-duplicate-selected-keyresults branch from 34204bc to 25109ce Compare November 29, 2024 15:27
@ManuelMoeri ManuelMoeri force-pushed the feature/614-duplicate-selected-keyresults branch from 557b08d to 14477a6 Compare December 9, 2024 07:09
MasterEvarior
MasterEvarior requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a lot to do but it looks already very promising and works flawlessly.
Keep up the good work

backend/src/main/java/ch/puzzle/okr/controller/ObjectiveController.java Outdated Show resolved Hide resolved
backend/src/main/java/ch/puzzle/okr/controller/ObjectiveController.java Outdated Show resolved Hide resolved
backend/src/main/java/ch/puzzle/okr/controller/ObjectiveController.java Outdated Show resolved Hide resolved
backend/src/main/java/ch/puzzle/okr/service/authorization/ObjectiveAuthorizationService.java Outdated Show resolved Hide resolved
...end/src/test/java/ch/puzzle/okr/service/authorization/ObjectiveAuthorizationServiceTest.java Outdated Show resolved Hide resolved
frontend/src/style/styles.scss Outdated Show resolved Hide resolved
frontend/src/app/services/objective.service.ts Show resolved Hide resolved
frontend/src/app/shared/dialog/objective-dialog/objective-form.component.spec.ts Show resolved Hide resolved
frontend/src/style/styles.scss Show resolved Hide resolved
frontend/src/app/shared/dialog/objective-dialog/objective-form.component.ts Show resolved Hide resolved
@ManuelMoeri ManuelMoeri force-pushed the feature/614-duplicate-selected-keyresults branch from 5e8110a to deb5f91 Compare December 11, 2024 14:45
@ManuelMoeri ManuelMoeri marked this pull request as ready for review December 13, 2024 10:18
nevio18324 and others added 22 commits December 13, 2024 11:19
@nevio18324 @ManuelMoeri
create new endpoint in Objectivecontroller
1d56786
@nevio18324 @ManuelMoeri
crate endpoint for getAllKeyResultsById
9e11b19
@nevio18324 @ManuelMoeri
modify duplicate e2e to accept new duplicateObjectDto now only select…
be28fc3 
…ed keyresults get added
@nevio18324 @ManuelMoeri
create new DuplicateObjectiveDto
095c0f6
@nevio18324 @ManuelMoeri
implement new duplication to frontend
d07ec38
@nevio18324 @ManuelMoeri
remove files added accidentally
c7ddfa5
@nevio18324 @ManuelMoeri
change duplicateObjective type to record instead of class
1d6e48a
@nevio18324 @ManuelMoeri
fix bug with id of objective already being defined when trying to dup…
757d311 
…licate
@nevio18324 @ManuelMoeri
fix bug that you couldnt edit objectives anymore
a393169
@nevio18324 @ManuelMoeri
fix bug that you can't add objectives anymore
2ebe457
@ManuelMoeri
Fix small typo
8f2f2e1
@ManuelMoeri
Reset run config
45f4b0c
@ManuelMoeri
Fix behaviour of duplicating objectives and small typo
3cd2323
@ManuelMoeri
Fix logic with creating and duplicating objective
eeaf7a2
@ManuelMoeri
Implement functionality to only show text at desired time and try to …
9bbed45 
…fix tests
@ManuelMoeri
Fix failing method calls for tests in backend
909e199
@ManuelMoeri
Cleanup ngOnInit in the objective-form component
f5c2bd5
@ManuelMoeri
Fix backend tests
4be6317
@ManuelMoeri
Fix frontend tests
996c28d
@ManuelMoeri
Reset ngOnInit since it caused a few problems and fix broken TestData
5be2334
@ManuelMoeri
Add method for e2e testing and first two e2e tests. Second one is not…
f2ff856 
… finished yet. Plus correct styling for selecting the keyresults
@actions-user @ManuelMoeri
[FM] Automated formating frontend
2465d07
@ManuelMoeri ManuelMoeri force-pushed the feature/614-duplicate-selected-keyresults branch from 44ceba4 to 8886046 Compare December 13, 2024 10:19
MasterEvarior
MasterEvarior approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for making all those finiky UI changes happen 😄

@MasterEvarior MasterEvarior merged commit 4f0882a into main Dec 13, 2024
18 checks passed
@MasterEvarior MasterEvarior deleted the feature/614-duplicate-selected-keyresults branch December 13, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peggimann peggimann peggimann left review comments

@ManuelMoeri ManuelMoeri ManuelMoeri left review comments

@MasterEvarior MasterEvarior MasterEvarior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyresults Duplizieren
5 participants
@nevio18324 @MasterEvarior @ManuelMoeri @peggimann @actions-user