Feature/1227 Fontsize and weight #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ManuelMoeri
commented
Dec 9, 2024
ManuelMoeri
commented
- Implement correct fontsize and weight across the whole tool.
21 tasks
MasterEvarior
requested changes
Dec 11, 2024
frontend/src/app/components/check-in-history-dialog/check-in-history-dialog.component.html
Show resolved
Hide resolved
ManuelMoeri
requested review from
MasterEvarior
and removed request for
MasterEvarior
ManuelMoeri
force-pushed
the
feature/1227-fontsize-and-weight
branch
from
aa15483 to
a5b2cd1
Compare
There was a problem hiding this comment.
UI looks good to me, the dialog scales correctly again and I could not see anything else that seemed out of order. I spotted this in the styles.scss file though:
a {
font-family: Roboto, "sans-serif";
font-variation-settings: "wght" 400;
color: $pz-dark-blue;
text-decoration: none;
font-size: 0.875rem;
font-weight: 700;
}Should both font-weight and font-variation-settings be present here? Does not one override the other one?
After that I think we are ready to merge
MasterEvarior
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.