Refactoring/refactor action plan #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcinay055679
changed the base branch from
main
to
feature/1293-kr-unit-autocomplete
kcinay055679
force-pushed
the
refactoring/refactor-action-plan
branch
from
5f7962a to
b7b627d
Compare
kcinay055679
changed the base branch from
feature/1293-kr-unit-autocomplete
to
main
kcinay055679
force-pushed
the
refactoring/refactor-action-plan
branch
2 times, most recently
from
5f371e0 to
3cbfc7d
Compare
kcinay055679
commented
Jan 28, 2025
There was a problem hiding this comment.
add more tests for actionplan (jest)
fix all disabled e2e tests
TODO:
- []
Use an=> Probably new ticket, but nobody cares tbh@Inputwhich takes an array of Items (maybe an observable of an array) and then generates the entries in onInit (or maybe afterContentInit) instead of the ReplaySubject - []
add custom validations for actionPlan
frontend/src/app/components/action-plan/action-plan.component.ts
Outdated
Show resolved
Hide resolved
| (change)="changeIsChecked($event, i)" | ||
| [checked]="action.isChecked" | ||
| formGroupName="id" |
frontend/src/app/components/key-result-form/key-result-form.component.ts
Outdated
Show resolved
Hide resolved
kcinay055679
force-pushed
the
refactoring/refactor-action-plan
branch
2 times, most recently
from
6acd6b4 to
ddb62ae
Compare
4 tasks
Miguel7373
force-pushed
the
refactoring/refactor-action-plan
branch
from
6f8e9c0 to
b6c53c8
Compare
RandomTannenbaum
previously approved these changes
Jan 31, 2025
There was a problem hiding this comment.
- Dont allow empty actions
- Deleting an item in the actionplan and the cancelling the dialog still deletes the item
- Opening the action edit on the check-in repeatedly exponentially adds more fields
- When adding an action in the check-in dialog, actions that are still empty should not be shown after saving
frontend/src/app/components/action-plan/action-plan.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/components/action-plan/action-plan.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/components/action-plan/action-plan.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/components/action-plan/action-plan.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/components/checkin/check-in-form/check-in-form.component.ts
Show resolved
Hide resolved
frontend/src/app/components/key-result-dialog/key-result-dialog.component.ts
Show resolved
Hide resolved
frontend/src/app/components/key-result-form/key-result-form.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/components/key-result-form/key-result-form.component.ts
Show resolved
Hide resolved
…hange logic for the delete load off actions
RandomTannenbaum
force-pushed
the
refactoring/refactor-action-plan
branch
from
8e13d50 to
7a94a37
Compare
MasterEvarior
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.