Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/319: Action plan #498

Merged
merged 68 commits into from
Nov 3, 2023
Merged

Feature/319: Action plan #498

merged 68 commits into from
Nov 3, 2023

Conversation

lkleisa
Copy link
Collaborator

@lkleisa lkleisa commented Oct 23, 2023

No description provided.

@lkleisa lkleisa self-assigned this Oct 23, 2023
@lkleisa lkleisa linked an issue Oct 23, 2023 that may be closed by this pull request
Okr - Erstellen eines Action plans #319
Closed
43 tasks
@lkleisa lkleisa force-pushed the feature/319-action-plan branch 3 times, most recently from 4aace8b to 2ac67a1 Compare October 30, 2023 14:31
@Vakmeth Vakmeth force-pushed the feature/319-action-plan branch from 620db48 to c56b2d6 Compare November 1, 2023 07:27
@lkleisa lkleisa force-pushed the feature/319-action-plan branch from e805773 to 784edcb Compare November 1, 2023 14:02
@lkleisa lkleisa marked this pull request as ready for review November 2, 2023 10:42
@lkleisa lkleisa requested a review from peggimann November 2, 2023 10:42
peggimann
peggimann requested changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@peggimann peggimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implement list on key result detail

backend/src/main/java/ch/puzzle/okr/service/business/ActionBusinessService.java Show resolved Hide resolved
backend/src/main/java/ch/puzzle/okr/service/persistence/ActionPersistenceService.java Outdated Show resolved Hide resolved
backend/src/main/java/ch/puzzle/okr/service/validation/ActionValidationService.java Show resolved Hide resolved
backend/src/main/resources/db/migration/V2_0_8__createActionTable.sql Outdated Show resolved Hide resolved
backend/src/test/java/ch/puzzle/okr/controller/KeyResultControllerIT.java Show resolved Hide resolved
@lkleisa lkleisa force-pushed the feature/319-action-plan branch from 747ebd3 to ddbf9f3 Compare November 2, 2023 16:04
@lkleisa
Copy link
Collaborator Author

lkleisa commented Nov 2, 2023

Fix bug with version when checking action and edit then keyresult

@lkleisa lkleisa marked this pull request as draft November 2, 2023 16:07
lkleisa and others added 17 commits November 3, 2023 07:46
@lkleisa
Add new model action
1fa6f4b
@lkleisa
Add new migration for action table
ddce377
@lkleisa
Add controller services repository mapper and dto for action
022fd57
@lkleisa
Adjust kr tests and test data for new action
c025120
@lkleisa
Add action in frontend with model component and service. Add material…
bda70f9 
… drag and drop and start with saving data in array
@RandomTannenbaum @lkleisa
embed actionplan on key-result
dbd9f0c
@lkleisa
Adjust styling of action plan
e7564f5
@lkleisa
Make possible to create multiple actions
9ae7656
@lkleisa
Add the action plan to keyresult in frontend and send it to backend
030bfd5
@lkleisa
Add checkboxes to check in dialog
5000a41
@lkleisa
Add transient actionList to keyresult model
a1e1fe4
@lkleisa
Adjust backend to create actions over keyresult create call
d280ba5
@lkleisa
Adjust frontend style and load actions in keyresult dialog
61bd299
@lkleisa
Update actions in frontend
2d5e34a
@lkleisa
Add update function for actions when creating new checkIn
4ae30d8
@lkleisa
Fix styling after rebase
f183afa
@lkleisa
Fix some tests with imports
ef1854b
lkleisa and others added 21 commits November 3, 2023 07:50
@lkleisa
Fix current backend tests
ddce427
@lkleisa
Fix bug with creating new actions
1eb44ab
@lkleisa
Write it test for actioncontroller
e2448f8
@lkleisa
Write it test for ActionAuthorizationService
faa17a6
@lkleisa
Write it test for ActionBusinessService
dadcae2
@lkleisa
Fix keyresult dialog test
4e9e51f
@Vakmeth @lkleisa
write frontend tests for action-plan
7218449
@lkleisa
Add some tests for KeyResultController
0d890e3
@lkleisa
Add some tests for KeyResultBusinessService
d6dfcc0
@lkleisa
Write test for ActionPersistenceService
ad09fcf
@lkleisa
Adjust action validation message
44724c0
@lkleisa
Write test for ActionValidationService
e3c3d24
@lkleisa
Fix ActionControllerIT
36cc797
@lkleisa
Add test for check-in-form.component
2410767
@lkleisa
Add test for check-in-base-informations.component
cb9c873
@lkleisa
Adjust test names for sonar
f0995ce
@lkleisa
Add exception message when deleting not authorized action
ebac599
@lkleisa
Add actionlist to keyresult detail
34cad23
@lkleisa
Resolve pr feedback
60da3a6
@lkleisa
Add version to action, adjust tests and remove bugs
4dc27f1
@lkleisa
Update frontend tests
85b1d28
@lkleisa lkleisa force-pushed the feature/319-action-plan branch from ddbf9f3 to 85b1d28 Compare November 3, 2023 07:05
@lkleisa lkleisa marked this pull request as ready for review November 3, 2023 08:30
@peggimann peggimann merged commit b3f54ca into main Nov 3, 2023
4 checks passed
@Miguel7373 Miguel7373 deleted the feature/319-action-plan branch October 31, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peggimann peggimann peggimann approved these changes

Assignees

@lkleisa lkleisa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Okr - Erstellen eines Action plans
5 participants
@lkleisa @peggimann @RandomTannenbaum @actions-user @Vakmeth