Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Interface config #158

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Feat: Interface config #158

wants to merge 16 commits into from

Conversation

kdhlab
Copy link
Contributor

@kdhlab kdhlab commented Sep 16, 2024

Draft for #157

@kdhlab kdhlab reopened this Jan 26, 2025
@kdhlab kdhlab marked this pull request as ready for review January 26, 2025 01:12
@kdhlab
Copy link
Contributor Author

kdhlab commented Jan 26, 2025

Summary of changes:

  1. Renamed the following files:
  • plugins/modules/interfaces_assignments.py to interfaces_configuration.py
  • plugins/module_utils/interfaces_assignments.py to interfaces_configuration.py
  1. Created a alias in meta/runtime.yml to ensure that if the old interfaces_assignments is called it will use the new module.
  2. Updated all references to interfaces_assignments to the new name.
  3. The updated ansible module allows you to set any valid key for an interface, it also allows you to delete interfaces.

Due to the possible permutations of configurations here I did not write any real tests or error checking outside of the basics.

@kdhlab kdhlab force-pushed the interface_config branch 2 times, most recently from f696e72 to 6589dd2 Compare January 26, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant