Move puzzle-shell to cdn in turn stopping css breakage

puzzle · Mar 22, 2024 · f1257df · f1257df
1 parent 8c946cc
commit f1257df
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/app/javascript/application.js b/app/javascript/application.js
@@ -1,4 +1,2 @@
 import "@hotwired/turbo-rails"
 import "./controllers"
-import "@puzzleitc/puzzle-shell";
-import "@puzzleitc/puzzle-shell/style.css";
diff --git a/app/views/layouts/application.html.haml b/app/views/layouts/application.html.haml
@@ -6,8 +6,10 @@
     %meta{:content => "width=device-width,initial-scale=1", :name => "viewport"}/
     = csrf_meta_tags
     = csp_meta_tag
+    = stylesheet_link_tag "application", "https://unpkg.com/@puzzleitc/puzzle-shell/dist/style.css"
     = stylesheet_link_tag "application", "data-turbo-track": "reload"
     = javascript_include_tag "application", "data-turbo-track": "reload", type: "module"
+    = javascript_include_tag "application", "https://unpkg.com/@puzzleitc/puzzle-shell/dist/bundle.js", type: "module"
     = favicon_link_tag "favicon.png"
   %body.d-flex.justify-content-center
     %div.content

diff --git a/spec/features/people_show_spec.rb b/spec/features/people_show_spec.rb
@@ -10,10 +10,8 @@
       visit skills_path
       click_link('Rails')
 
-      # We used visible false in this test because the modal is not accessible in any different way
-      # follow-up ticket for this: #628
-      expect(page).to have_selector('.modal-title', visible: false, text: 'Skill: Rails (4 Members)')
-      expect(page).to have_selector('.skill-row', visible: false, count: 4)
+      expect(page).to have_selector('.modal-title', text: 'Skill: Rails (4 Members)')
+      expect(page).to have_selector('.skill-row', count: 4)
   end
 
   it 'Should render elements correctly' do