Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/408 emberjs tests GitHub actions #416

Merged
merged 16 commits into from
Mar 2, 2021
Merged

Feature/408 emberjs tests GitHub actions #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
143c29d
#408: add frontend tests to github actions
Feb 23, 2021
7997d28
#408: fix indent
Feb 23, 2021
9a97a35
#408: use node and yarn to execute frontend test
Feb 23, 2021
d913ffc
#408: fix indent bis
Feb 23, 2021
34bf694
#410: use rake to run frontend tests
Feb 23, 2021
e38a081
#410: add ember install
Feb 23, 2021
ddc7eea
#408: add log
Feb 23, 2021
1f3da58
#410: add working directory npm, remove logs
Feb 23, 2021
f939cb8
#410: specify ember version
Feb 23, 2021
805ae33
#408: add working dir for yarn, remove not working cache
Feb 24, 2021
b77ae7d
#408: add yarn cache
Feb 24, 2021
d6b6ccd
#408: remove wrong attribute
Feb 24, 2021
a88f090
#408: add existing action for yarn and node cache
Feb 24, 2021
7b235f1
#408: add working directory
Feb 24, 2021
d99687b
#408: remove not working cache, add comments
Feb 24, 2021
b0dc2fd
Merge branch 'master' into feature/408_emberjs_tests_github_actions
Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/rails.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,17 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- uses: actions/setup-node@v2
with:
node-version: '8' # TODO version should not be specified

- name: Install Ember-Cli with NPM
run: npm install -g [email protected] # TODO version should not be specified
working-directory: frontend

- name: Install dependencies Yarn
run: yarn install --frozen-lockfile
working-directory: frontend

- name: Setup test database
env:
Expand All @@ -45,3 +56,6 @@ jobs:

- name: Run RuboCop
run: bundle exec rubocop --parallel

- name: Run Frontend Tests
run: bundle exec rake spec:frontend
2 changes: 0 additions & 2 deletions bin/frontend-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ esac

rails server -e test -d -p $RAILS_PORT -P $PID_FILE
rc=$?; if [[ $rc != 0 ]]; then exit $rc; fi

cd frontend
if [[ $SERVER == true ]]; then
ember test --server
Expand All @@ -22,7 +21,6 @@ else
fi
rc=$?
cd ..

kill -INT $(cat $PID_FILE)

exit $rc