Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/601 people dropdown #610

Merged
merged 36 commits into from
Feb 23, 2024
Merged

Feature/601 people dropdown #610

merged 36 commits into from
Feb 23, 2024

Conversation

kcinay055679
Copy link
Collaborator

No description provided.

@kcinay055679 kcinay055679 self-assigned this Feb 20, 2024
@kcinay055679 kcinay055679 linked an issue Feb 20, 2024 that may be closed by this pull request
@kcinay055679 kcinay055679 marked this pull request as ready for review February 22, 2024 13:53
Copy link
Member

@Robin481 Robin481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good!
Some nitpicking and then we are good 🚀

.npmrc Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
Gemfile Show resolved Hide resolved
Procfile.assets Show resolved Hide resolved
app/controllers/people_controller.rb Show resolved Hide resolved
app/views/people/_search.html.haml Outdated Show resolved Hide resolved
@Robin481 Robin481 merged commit 1a17c42 into master Feb 23, 2024
2 checks passed
@Robin481 Robin481 deleted the feature/601-select-peopole branch February 23, 2024 14:00
kcinay055679 added a commit that referenced this pull request Mar 1, 2024
* add stimulus controller to redirect with 2nd select with normal link to syntax

* update people show

* rename controller to dropdown_controller.js

* create 2nd run proifle

* show dropdown as partial and select correct default value

* add tests

* clean up

* fix pipeline

* update pry-byebug and specify feature as target for headless test

* add husky

* fix npm config

* fix capybara config

* fix pipeline

* fix pipeline

* add chrome to github action

* fix pipeline

* fix pipeline

* fix pipeline

* fix pipeline

* fix pipelien

* use specific chrome

* fix pipelien

* fix pipeline

* fix pipeline

* update gemfile

* fix pipeline

* fix pipeliebn

* fix pipeline

* reuse chrome

* inshalla

* fasdf

* clean up

* clean up

* clean up

* fix typo

* resolve conversations from PR

---------

Co-authored-by: Yanick Minder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New-Skills: Add people search dropown
2 participants