Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ptime mapper script #737

Draft
wants to merge 80 commits into
base: master
Choose a base branch
from
Draft

Ptime mapper script #737

wants to merge 80 commits into from

Commits on Jun 21, 2024

  1. Create migration to add ptime id to person model

    @RandomTannenbaum
    RandomTannenbaum committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a77a77d View commit details
    Browse the repository at this point in the history

  2. Start writing mapper script

    @RandomTannenbaum
    RandomTannenbaum committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    665bf0b View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Implement basic PTime client class and install webmock gem

    @ManuelMoeri
    ManuelMoeri committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2f1660f View commit details
    Browse the repository at this point in the history

  2. Create new migration to fix naming of ptime_emplyoee_id attribute

    @ManuelMoeri
    ManuelMoeri committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0555ec7 View commit details
    Browse the repository at this point in the history

  3. Add first test to see how webmock works

    @ManuelMoeri
    ManuelMoeri committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    83fa511 View commit details
    Browse the repository at this point in the history

  4. Fix first client spec

    @RandomTannenbaum
    RandomTannenbaum committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    fbc8987 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Write json body to test employee endpoint

    @RandomTannenbaum
    RandomTannenbaum committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6a75e33 View commit details
    Browse the repository at this point in the history

  2. Fix tests by allowing localhost connection and write negative test fo… 

    …r the ptime client
    @RandomTannenbaum
    RandomTannenbaum committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6a9a89a View commit details
    Browse the repository at this point in the history

  3. Make ptime client specs not read values from env variables

    @RandomTannenbaum
    RandomTannenbaum committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9ddd723 View commit details
    Browse the repository at this point in the history

  4. Set error messages on errors in client and change test data urls to e… 

    …xample.com
    @RandomTannenbaum
    RandomTannenbaum committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7ab6727 View commit details
    Browse the repository at this point in the history

  5. Fix params of ptime client and implement basic mapper script

    @RandomTannenbaum
    RandomTannenbaum committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8f85e91 View commit details
    Browse the repository at this point in the history

  6. Add new tests and remove unnecessary

    @RandomTannenbaum
    RandomTannenbaum committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f945378 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Add test for ambiguous matched people

    @ManuelMoeri
    ManuelMoeri committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    933c2fc View commit details
    Browse the repository at this point in the history

  2. Add email to filter before matching as well

    @ManuelMoeri
    ManuelMoeri committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ff37bcc View commit details
    Browse the repository at this point in the history

  3. Possibly make rubocop happy

    @ManuelMoeri
    ManuelMoeri committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    244369f View commit details
    Browse the repository at this point in the history

  4. Try to make rubocop happy again

    @ManuelMoeri
    ManuelMoeri committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7e58084 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Add evaluate task for mapping script

    @RandomTannenbaum
    RandomTannenbaum committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    132424a View commit details
    Browse the repository at this point in the history

  2. Outsource mapper script code to methods and fix tests

    @RandomTannenbaum
    RandomTannenbaum committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2070ffb View commit details
    Browse the repository at this point in the history

  3. Add test for dry run

    @RandomTannenbaum
    RandomTannenbaum committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b89c933 View commit details
    Browse the repository at this point in the history

  4. Make rubocop happy :)

    @RandomTannenbaum
    RandomTannenbaum committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b44a2d0 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary requires

    @RandomTannenbaum
    RandomTannenbaum committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f9be66c View commit details
    Browse the repository at this point in the history

  6. Replace .count == 1 with .one?

    @RandomTannenbaum
    RandomTannenbaum committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    104185e View commit details
    Browse the repository at this point in the history

  7. Start writing script that updates the data of the people in skills

    @RandomTannenbaum
    RandomTannenbaum committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    aa4c5f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Write script that maps the data from a ptime employee to the correspo… 

    …nding skills person
    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7d775c3 View commit details
    Browse the repository at this point in the history

  2. Disable rubocop metrics all together instead of one by one in assign … 

    …employee id and update people data scripts
    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    82d03f0 View commit details
    Browse the repository at this point in the history

  3. Fix file naming of spec files

    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    96913d2 View commit details
    Browse the repository at this point in the history

  4. Move class into module and fix mapping of person to employee data, wr… 

    …ite specs to test mapping of people data
    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    907da90 View commit details
    Browse the repository at this point in the history

  5. Fix updating of people data and test it and fix faulty key in json us… 

    …ed for testing requests
    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    35f4b0d View commit details
    Browse the repository at this point in the history

  6. Fix update people data specs by assigning the ptime base url env var … 

    …in before each
    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1190569 View commit details
    Browse the repository at this point in the history

  7. Only update ptime employee id if its not already set

    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5ac5585 View commit details
    Browse the repository at this point in the history

  8. Test if marital status can be changed in specs

    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8c8e0e4 View commit details
    Browse the repository at this point in the history

  9. Write rake task that runs the people update

    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    dd0bacd View commit details
    Browse the repository at this point in the history

  10. Show message in assign employee ids script conditionally

    @RandomTannenbaum
    RandomTannenbaum committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b2d5d0b View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Add delayed jobs and daemon gems and start writing delayed jobs

    @RandomTannenbaum
    RandomTannenbaum committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    dbe7132 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fix specs to work with delayed job

    @RandomTannenbaum
    RandomTannenbaum committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6fb4df1 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Remove delayed job functionality

    @RandomTannenbaum
    RandomTannenbaum committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    480e328 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Add first approach for fetching people from ptime API

    @ManuelMoeri
    ManuelMoeri committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    138fab7 View commit details
    Browse the repository at this point in the history

  2. Add helper and write test for fetching employee data

    @ManuelMoeri
    ManuelMoeri committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    7f6abdd View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Finish test and fix logic in displaying people

    @ManuelMoeri
    ManuelMoeri committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ea3d4e5 View commit details
    Browse the repository at this point in the history

  2. Implement correct routing of person and fix a problem in the docker s… 

    …etup with yminder
    @ManuelMoeri
    ManuelMoeri committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3a6b7c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Possibly fix docker compose file

    @ManuelMoeri
    ManuelMoeri committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c25e18c View commit details
    Browse the repository at this point in the history

  2. Fix tests and implement logic for sorting people

    @ManuelMoeri
    ManuelMoeri committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4385c4a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Implement logic for fallback and cleanup helper method

    @ManuelMoeri
    ManuelMoeri committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    202006a View commit details
    Browse the repository at this point in the history

  2. Improve fallback logic by making it more readable and shorter

    @ManuelMoeri
    ManuelMoeri committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1dc3065 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Implement first approach on calling the ptime api after 5 minutes

    @ManuelMoeri
    ManuelMoeri committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1267736 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Improve logic of 5 minutes request and change client.rb

    @ManuelMoeri
    ManuelMoeri committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    512593b View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add logic to load site correctly and remove unnecessary code

    @ManuelMoeri
    ManuelMoeri committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c9e9825 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Fix logic of rendering people and cleanup code

    @ManuelMoeri
    ManuelMoeri committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    39acf6e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Add tests for person_helper

    @ManuelMoeri
    ManuelMoeri committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d967660 View commit details
    Browse the repository at this point in the history

  2. Add ptime_helpers to cleanup code

    @ManuelMoeri
    ManuelMoeri committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c657e8f View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @ManuelMoeri
    ManuelMoeri committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bcb3ebe View commit details
    Browse the repository at this point in the history

  4. Fix last test and remove pry

    @ManuelMoeri
    ManuelMoeri committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    456f27b View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Fix test and add comment

    @ManuelMoeri
    ManuelMoeri committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4718e92 View commit details
    Browse the repository at this point in the history

  2. Generalize window resizing of capybara

    @ManuelMoeri
    ManuelMoeri committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bf771aa View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Cleanup code and add comments

    @ManuelMoeri
    ManuelMoeri committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    189ab80 View commit details
    Browse the repository at this point in the history

  2. Add one more test for client.rb

    @ManuelMoeri
    ManuelMoeri committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2e2ae6b View commit details
    Browse the repository at this point in the history

  3. Reverse test from last commit

    @ManuelMoeri
    ManuelMoeri committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    766e942 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. change location of helper

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    aa36e82 View commit details
    Browse the repository at this point in the history

  2. set ptime stubing global

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4153a5b View commit details
    Browse the repository at this point in the history

  3. clean up ptime client specs

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    87d84d8 View commit details
    Browse the repository at this point in the history

  4. create json file for fixtures

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    96391b2 View commit details
    Browse the repository at this point in the history

  5. use hashes instead of strings for json keys create global ptime stub … 

    …method
    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    cce291b View commit details
    Browse the repository at this point in the history

  6. use custom ptime stubbing method everywhere

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d3bb9c3 View commit details
    Browse the repository at this point in the history

  7. fix tests after always using [:data]

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    dd96900 View commit details
    Browse the repository at this point in the history

  8. clean up ptime client

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0d1c4ff View commit details
    Browse the repository at this point in the history

  9. improve structure of people search

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7550234 View commit details
    Browse the repository at this point in the history

  10. Client isn't longer controlled by random env vars

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    552cf7d View commit details
    Browse the repository at this point in the history

  11. simplify ptime_helpers

    @kcinay055679
    kcinay055679 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d9c02be View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. clean up PR

    @kcinay055679
    kcinay055679 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    44d76bd View commit details
    Browse the repository at this point in the history

  2. Clean up Skills db fallback logic

    @kcinay055679
    kcinay055679 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    71db98a View commit details
    Browse the repository at this point in the history

  3. improve readability by using more helper

    @kcinay055679
    kcinay055679 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3a7997a View commit details
    Browse the repository at this point in the history

  4. clean up

    @kcinay055679
    kcinay055679 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d19bd8e View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. add client test

    @kcinay055679
    kcinay055679 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    57ad58a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #748 from puzzle/feature/745-fetch-people-search-e… 

    …ntries-from-ptime

feature/745 fetch people search entries from ptime
    @kcinay055679
    kcinay055679 authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5411381 View commit details
    Browse the repository at this point in the history

  3. ds muäs so

    @kcinay055679
    kcinay055679 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    af3def7 View commit details
    Browse the repository at this point in the history

  4. so its aber

    @kcinay055679
    kcinay055679 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2763d61 View commit details
    Browse the repository at this point in the history

  5. Resolve conversations

    @RandomTannenbaum
    RandomTannenbaum committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d272a03 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Remove unneeded spec and fix spec that tests the not found case when … 

    …mapping
    @RandomTannenbaum
    RandomTannenbaum committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    48fb6be View commit details
    Browse the repository at this point in the history

  2. Fix order of name interpolation in id mapper script

    @RandomTannenbaum
    RandomTannenbaum committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a52ceaa View commit details
    Browse the repository at this point in the history

  3. Update json fixtures and use full_name instead of interpolating it

    @RandomTannenbaum
    RandomTannenbaum committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    65fb684 View commit details
    Browse the repository at this point in the history