Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/728 language clean up #743

Merged
merged 82 commits into from
Aug 8, 2024
Merged

Feature/728 language clean up #743

merged 82 commits into from
Aug 8, 2024

Conversation

kcinay055679
Copy link
Collaborator

No description provided.

@kcinay055679 kcinay055679 force-pushed the feature/728-language-clean-up branch 2 times, most recently from ea8e96f to cc0987d Compare July 5, 2024 15:49
@kcinay055679 kcinay055679 force-pushed the feature/728-language-clean-up branch 3 times, most recently from 1076beb to 233a7d1 Compare July 23, 2024 09:00
@kcinay055679 kcinay055679 marked this pull request as ready for review July 24, 2024 12:25
Robin481
Robin481 requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Robin481 Robin481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot to improve...

Furthermore

  1. the CV Search is also broken and always redirects to a Person's Skills instead of the place where the result was found... And the translation is also broken there.
  2. The export Icon is not fitting
  3. Interest in the skill search is not translated
  4. Admin Panel is not translated
  5. The CV / Skills tab don't work when opening a profile

Gemfile Outdated Show resolved Hide resolved
app/domain/people_search.rb Outdated Show resolved Hide resolved
app/helpers/auth_helper.rb Outdated Show resolved Hide resolved
app/helpers/date_helper.rb Outdated Show resolved Hide resolved
app/helpers/date_helper.rb Show resolved Hide resolved
lib/custom_translation_matchers/dry_crud_ti_scanner.rb Outdated Show resolved Hide resolved
spec/features/cv_search_spec.rb Outdated Show resolved Hide resolved
spec/features/people_skill_search_spec.rb Outdated Show resolved Hide resolved
spec/features/people_spec.rb Outdated Show resolved Hide resolved
spec/features/people_spec.rb Outdated Show resolved Hide resolved
@kcinay055679
Copy link
Collaborator Author

kcinay055679 commented Jul 26, 2024 •
edited
Loading

  • the CV Search is also broken and always redirects to a Person's Skills instead of the place where the result was found
  • CV Search translation is also broken there.
  • The export Icon is not fitting
  • Interest in the skill search is not translated
  • Admin Panel is not translated
  • The CV / Skills tab don't work when opening a profile

@kcinay055679
create language selector dropdown
e6bf306
@kcinay055679
translate languages
b056696
@kcinay055679
change position of selector
d147337
@kcinay055679
add translations check
2c6604f
@kcinay055679
add attr translation for object
60063f9
@kcinay055679
update translations for people profile and add cancel form button
8753378
@kcinay055679
add translations for people_skills and language select
f2a65a5
@kcinay055679
fix human_attribute_name method
54a6eb8
@kcinay055679
use instance for translations
20b7bf7
@kcinay055679
add translation for sv_export
a81b123
@kcinay055679
Update translate and action_link helper
9ef2fc1
@kcinay055679
update translations
84f718b
@kcinay055679
add more action_link helper
d75b7ba
@kcinay055679
update translations till _cv.html
58be547
@kcinay055679
Fix translations for people
23093cc
@kcinay055679
update translations for people_skills
6368754
@kcinay055679
translate all person_relations
4db88aa
@kcinay055679
update translations for admin panel
22cf647
@kcinay055679
update skills translations
4b59f8f
@kcinay055679
add custom rubocop
6b88556
@kcinay055679 kcinay055679 force-pushed the feature/728-language-clean-up branch from 55d54cb to b8e9a1e Compare July 31, 2024 10:04
kcinay055679
kcinay055679 commented Aug 2, 2024
View reviewed changes
spec/rails_helper.rb Outdated Show resolved Hide resolved
Robin481
Robin481 requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Robin481 Robin481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good.

One more thing:
The languages in the dropdown should always be in their respective language. E.g. English should always be English, never Inglese, even if you are currently using Italian.

app/assets/stylesheets/crud.scss Outdated Show resolved Hide resolved
app/controllers/people_skills/filter_params.rb Show resolved Hide resolved
@Robin481 Robin481 self-requested a review August 8, 2024 11:58
@Robin481 Robin481 merged commit d3a7f14 into master Aug 8, 2024
2 checks passed
@Robin481 Robin481 deleted the feature/728-language-clean-up branch August 8, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin481 Robin481 Robin481 approved these changes

Assignees

@Robin481 Robin481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcinay055679 @Robin481