Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json #759

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

marcoroth
Copy link
Contributor

The package.json states that we should be using yarn:

"npm": "please-use-yarn",

Though we still have the package-lock.json checked into the repo, which is usually an artifact generated by npm.

Bundlers like yarn also warn you about this when running yarn install:

❯ yarn install 
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not
 to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear thi
s warning, remove package-lock.json.

That's why I thought I open this pull request to remove the package-lock.json since we are not using npm.

@Robin481
Copy link
Member

Heya @marcoroth
Thanks a lot for your PRs, I was on holidays the last two weeks so forgive my delayed response.

You are of course very correct, someone must have pushed this by accident.

I'll be looking at your other PR in the next few days. ✌️

P.S: I enjoyed your talk at RubyConf a lot and it is a big joy to see a PR of yours!

@Robin481 Robin481 self-requested a review August 26, 2024 06:47
@Robin481 Robin481 merged commit af797a8 into puzzle:master Aug 26, 2024
1 check passed
@marcoroth marcoroth deleted the remove-package-lock branch August 26, 2024 14:31
@marcoroth
Copy link
Contributor Author

Hey @Robin481, thank you! And no worries! 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants