Generate git version and include that in source output #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrm, this focal environment is getting a security violation with its efi shell: I don't get that on a local focal system. |
raharper
force-pushed
the
feat/include-version-in-source-v2
branch
from
aaac3f4
to
4d247aa
Compare
The current GIT_VERSION value only works if you build from a git repo. Once we release on github, the tarballs that one can download are not git repos and the git command to describe the version fail. Generate the git version value and write to a file. In source tarball builds, the value will come from the file rather than git. - Add 'show-version' as makefile target - Add 'show-version' to github workflow - Adjust make-tarball tool to insert the git-version file Signed-off-by: Ryan Harper <[email protected]>
…debug - Drop ovmf down to restore use of uefi-shell in secureboot mode - Update collect-firmwares to use correct ovmf version - Only print serial log if args verbose is set
raharper
force-pushed
the
feat/include-version-in-source-v2
branch
from
7f44a2d
to
3666982
Compare
hallyn
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current GIT_VERSION value only works if you build from a git repo. Once we release on github, the tarballs that one can download are not git repos and the git command to describe the version fail.
Generate the git version value and write to a file. In source tarball builds, the value will come from the file rather than git.
Fixes: #45