Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CUDA optional for at least the main lib #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rpavlik
Copy link

@rpavlik rpavlik commented Jul 6, 2021

  • Make CUDA optional in the build system.
  • Make lm_optimizer.h compile without cuda if desired.
  • Slight cuda-related CMake cleanup

I wasn't able to easily make the app build without cuda, unfortunately. Are there any plans to support that? I'll push my WIP.

@puzzlepaint
Copy link
Owner

Thank you very much for this and the WIP PR. It seems to me that this one should be merged only once the other one is also ready, since libvis on its own is probably not really useful, and thus the CMake error message about the missing CUDA SDK in the top-level CMakeLists.txt should probably be kept as long as the application does not compile without CUDA.

I wasn't able to easily make the app build without cuda, unfortunately. Are there any plans to support that?

In general, this repo was created to open-source the code for a specific project while I did my PhD. In the meantime, I finished the PhD and currently do not have any plans for active development of the project. However, I try to do basic maintenance (handling issues and PRs) in my spare time and will gladly merge a PR for making CUDA an optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants