Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect units pvlib.ivtools.sdm.fit_desoto #2319

Open
RDaxini opened this issue Dec 3, 2024 · 0 comments
Open

Incorrect units pvlib.ivtools.sdm.fit_desoto #2319

RDaxini opened this issue Dec 3, 2024 · 0 comments
Labels
documentation easy good first issue help wanted
Milestone
v0.11.2

Comments

@RDaxini
Copy link
Contributor

RDaxini commented Dec 3, 2024

Is your feature request related to a problem? Please describe.
Units of dEg/dT in pvlib.ivtools.sdm.fit_desoto should be 1/K, not eV/K

Describe the solution you'd like
Correct the units

Additional context
Comment

Marking as good first issue for a new contributor, but I could fix this if no-one does it before 11.2 release if we want it done by then.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation easy good first issue help wanted
Projects
None yet
Milestone
v0.11.2
Development

No branches or pull requests
1 participant
@RDaxini