Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia #2317

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Dec 3, 2024

  • Closes Parameters missing from ivtools.sdm.fit_desoto_sandia returns statement #2315
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini added this to the v0.11.2 milestone Dec 3, 2024
@RDaxini RDaxini marked this pull request as ready for review December 3, 2024 17:21
@RDaxini RDaxini marked this pull request as draft December 3, 2024 17:22
pvlib/ivtools/sdm.py Outdated Show resolved Hide resolved
@RDaxini RDaxini marked this pull request as ready for review December 3, 2024 17:27
@RDaxini RDaxini changed the title [WIP] Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia Dec 3, 2024
pvlib/ivtools/sdm.py Outdated Show resolved Hide resolved
Co-authored-by: Kevin Anderson <[email protected]>
pvlib/ivtools/sdm.py Outdated Show resolved Hide resolved
Co-authored-by: Cliff Hansen <[email protected]>
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RDaxini

@kandersolar kandersolar merged commit a17da47 into pvlib:main Dec 3, 2024
26 checks passed
@RDaxini RDaxini deleted the sdm_returns branch December 3, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters missing from ivtools.sdm.fit_desoto_sandia returns statement
3 participants