Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters to returns statement in ivtools.sdm.fit_desoto_sandia #2317

Merged
merged 5 commits into from
Dec 3, 2024
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions pvlib/ivtools/sdm.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,25 +564,36 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3):
I_L_ref : float
light current at STC [A]
RDaxini marked this conversation as resolved.
Show resolved Hide resolved
I_o_ref : float
dark current at STC [A]
Dark current at STC [A]
EgRef : float
effective band gap at STC [eV]
Effective band gap at STC [eV]
R_s : float
series resistance at STC [ohm]
Series resistance at STC [ohm]
R_sh_ref : float
shunt resistance at STC [ohm]
Shunt resistance at STC [ohm]
cells_in_series : int
number of cells in series
Number of cells in series
iph : array
light current for each IV curve [A]
Light current for each IV curve [A]
io : array
dark current for each IV curve [A]
Dark current for each IV curve [A]
rs : array
series resistance for each IV curve [ohm]
Series resistance for each IV curve [ohm]
rsh : array
shunt resistance for each IV curve [ohm]
Shunt resistance for each IV curve [ohm]
a_ref : float
The product of the usual diode ideality factor (n, unitless),
number of cells in series (Ns), and cell thermal voltage at
reference conditions, in units of V.
dEgdT : float
The temperature dependence of the energy bandgap (Eg) at reference
conditions [eV/K]. May be either a scalar value
RDaxini marked this conversation as resolved.
Show resolved Hide resolved
(e.g. -0.0002677 as in [1]_) or a DataFrame (this may be useful if
dEgdT is a modeled as a function of temperature). For parameters
from the SAM CEC module database, dEgdT=-0.0002677 is implicit for
all cell types in the parameter estimation algorithm used by NREL.
u : array
boolean for each IV curve indicating that the parameter values
Boolean for each IV curve indicating that the parameter values
are deemed reasonable by the private function ``_filter_params``

Notes
Expand Down
Loading