Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update racking_model options in PVSystem and FixedMount classes #2232

Merged
merged 23 commits into from
Nov 15, 2024

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Sep 28, 2024

@RDaxini
Copy link
Contributor Author

RDaxini commented Sep 28, 2024

I have limited these changes to PVSystem and FixedMount only as these are the two classes mentioned in #1942
I could make further edits, e.g. more formatting, update/add default values for the same (and other) parameters in the other docstrings, etc. either in this PR if recommended, or in a follow up PR if this would become too cluttered (please advise)

@RDaxini RDaxini marked this pull request as ready for review September 28, 2024 21:07
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with limiting the formatting fixes to the functions/classes touched by the primary purpose of the PR.

pvlib/pvsystem.py Outdated Show resolved Hide resolved
pvlib/pvsystem.py Outdated Show resolved Hide resolved
@cwhanse cwhanse added this to the v0.11.2 milestone Sep 29, 2024
pvlib/pvsystem.py Outdated Show resolved Hide resolved
pvlib/pvsystem.py Outdated Show resolved Hide resolved
pvlib/pvsystem.py Outdated Show resolved Hide resolved
pvlib/pvsystem.py Outdated Show resolved Hide resolved
pvlib/pvsystem.py Outdated Show resolved Hide resolved
docs/sphinx/source/whatsnew/v0.11.2.rst Outdated Show resolved Hide resolved
docs/sphinx/source/whatsnew/v0.11.2.rst Show resolved Hide resolved
pvlib/pvsystem.py Outdated Show resolved Hide resolved
pvlib/pvsystem.py Outdated Show resolved Hide resolved
@RDaxini RDaxini changed the title Correct racking_model default value, add freestanding option Update racking_model options in PVSystem and FixedMount classes Nov 12, 2024
@RDaxini
Copy link
Contributor Author

RDaxini commented Nov 13, 2024

Good to go?

@kandersolar
Copy link
Member

One more thing -- can we copy the new racking_model description to SingleAxisTrackerMount as well?

@RDaxini
Copy link
Contributor Author

RDaxini commented Nov 15, 2024

One more thing -- can we copy the new racking_model description to SingleAxisTrackerMount as well?

I think I did originally somewhere in a past commit, but then after some discussion about scope and what was mentioned in the original issue, I reverted that... I'll go ahead and redo!

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RDaxini!

@kandersolar kandersolar merged commit 633ea87 into pvlib:main Nov 15, 2024
26 checks passed
@RDaxini
Copy link
Contributor Author

RDaxini commented Nov 15, 2024

Thanks both for your input and reviewing !

@RDaxini RDaxini deleted the pvsystem_racking branch November 15, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants