-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update racking_model
options in PVSystem and FixedMount classes
#2232
Conversation
I have limited these changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with limiting the formatting fixes to the functions/classes touched by the primary purpose of the PR.
Co-authored-by: Cliff Hansen <[email protected]>
Co-Authored-By: Cliff Hansen <[email protected]>
…ython into pvsystem_racking
Co-authored-by: Kevin Anderson <[email protected]>
…ython into pvsystem_racking
Co-authored-by: Kevin Anderson <[email protected]>
…ython into pvsystem_racking
racking_model
default value, add freestanding
optionracking_model
options in PVSystem and FixedMount classes
Good to go? |
One more thing -- can we copy the new |
I think I did originally somewhere in a past commit, but then after some discussion about scope and what was mentioned in the original issue, I reverted that... I'll go ahead and redo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RDaxini!
Thanks both for your input and reviewing ! |
racking_module
andmodule_type
inPVSystem
docstring #1942Tests addedUpdates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.