Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: params & units guidelines in contributing page #2248

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Oct 9, 2024

Improve "contributing" guidelines on how to find parameter names and their units.

In coordination with style decided in #2234.

Makes two changes to index pages of functions, to avoid being too verbose and a typo.

Links

@echedey-ls echedey-ls changed the title Docstring guidelines params&units [DOC]: params & units guidelines in contributing page Oct 9, 2024
@echedey-ls echedey-ls marked this pull request as ready for review October 9, 2024 16:20
Copy link
Contributor

@RDaxini RDaxini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Couple of suggestions + one point about the link to the variables page

docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
@echedey-ls echedey-ls marked this pull request as ready for review November 27, 2024 22:59
@echedey-ls
Copy link
Contributor Author

Ready for review (thx Dax for reminding me xD). Preview linked in PR body.
Assigning to v0.11.2 for now.

@echedey-ls echedey-ls added this to the v0.11.2 milestone Nov 27, 2024
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great addition this will be 🥳

docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standarizing pvlib typesetting of units - standarization for common variables?
3 participants