Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up pvlib.ivtools.sdm into a subpackage organized by SDM #2256

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Oct 11, 2024

  • Closes Proposal: split up pvlib/ivtools/sdm.py #2252
  • I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR splits pvlib.ivtools.sdm into a subpackage with the following structure:

  • ivtools/sdm/cec.py: fit_cec_sam
  • ivtools/sdm/desoto.py: fit_desoto, fit_desoto_sandia
  • ivtools/sdm/pvsyst.py: fit_pvsyst_sandia, pvsyst_temperature_coeff
  • ivtools/sdm/_fit_desoto_pvsyst_sandia.py: helper functions for fit_pvsyst_sandia and fit_desoto_sandia

@kandersolar kandersolar marked this pull request as ready for review October 15, 2024 13:31
@kandersolar kandersolar added this to the v0.11.2 milestone Oct 15, 2024
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reorganization looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: split up pvlib/ivtools/sdm.py
2 participants