Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate Relative Humidity via Magnus Tetens Equation #2286
base: main
Are you sure you want to change the base?
Calculate Relative Humidity via Magnus Tetens Equation #2286
Changes from 12 commits
70e0156
0ec0cbf
5eb9d00
ab2de3a
f62bd8e
77025c7
b52f9a9
58b246e
a06871a
caa4417
edd84b1
9c32f6a
63ed5c7
6312f92
410e95f
d94df47
e6b5908
63a9226
459d5a6
05b846f
0ae31e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 363 in pvlib/atmosphere.py
GitHub Actions / flake8-linter
Check failure on line 364 in pvlib/atmosphere.py
GitHub Actions / flake8-linter
Check failure on line 398 in pvlib/atmosphere.py
GitHub Actions / flake8-linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that
atmosphere.py
is a better home for this functionalityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved in latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to remove this
magnus_tetens.py
fileCheck failure on line 37 in pvlib/spectrum/magnus_tetens.py
GitHub Actions / flake8-linter
Check failure on line 490 in pvlib/tests/conftest.py
GitHub Actions / flake8-linter
Check failure on line 91 in pvlib/tests/test_atmosphere.py
GitHub Actions / flake8-linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness, let's add corresponding tests where the inputs are float and array. We will also need to include tests where alternative coefficient values are specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kandersolar just reworked the unit tests, I added tests which take in a numpy array and a float as well as a pandas series with a different set of coefficients. Let me know what you think, happy to adjust in any way.
Check failure on line 124 in pvlib/tests/test_atmosphere.py
GitHub Actions / flake8-linter