-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing subscript #2296
fix: missing subscript #2296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FelixKoTU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting and fixing this @FelixKoTU.
Shall we expand the scope a little bit? We could link the references properly in line 20: by Jain and Kapoor _[1] _[2], and Hansen _[3].
We could also standardize the formatting of the reference list. See here for further info
photovoltaic cell interconnection circuits" JW Bishop, Solar Cell (1988) | ||
:doi:`10.1016/0379-6787(88)90059-2` No newline at end of file | ||
:doi:`10.1016/0379-6787(88)90059-2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here? It looks like nothing happened, but it shows as a change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an oversight on my part, I did not mean to alter that line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could link the references properly in line 20: by Jain and Kapoor _[1] _[2], and Hansen _[3].
We could also standardize the formatting of the references
Only if @FelixKoTU wants to, in my view.
This page really doesn't fit in a User Guide, it's more of detailed background we ought to have somewhere but didn't know where else to put it. My point is that we ought to consider rewriting this page and editing the references can be done in that revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if @FelixKoTU wants to, in my view.
This page really doesn't fit in a User Guide, it's more of detailed background we ought to have somewhere but didn't know where else to put it. My point is that we ought to consider rewriting this page and editing the references can be done in that revision.
Fair point!
I think it's whether the line ends in Doesn't really matter IMHO. Thanks @FelixKoTU! |
for sure no big deal I was kinda just curious 😅 |
Subscript "s" is missing for the number of cells in series (N_s) in latex math expressions.