Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing subscript #2296

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: missing subscript #2296

merged 1 commit into from
Nov 19, 2024

Conversation

FelixKoTU
Copy link
Contributor

Subscript "s" is missing for the number of cells in series (N_s) in latex math expressions.

Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FelixKoTU

Copy link
Contributor

@RDaxini RDaxini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this @FelixKoTU.
Shall we expand the scope a little bit? We could link the references properly in line 20: by Jain and Kapoor _[1] _[2], and Hansen _[3]. We could also standardize the formatting of the reference list. See here for further info

Comment on lines 112 to 114
photovoltaic cell interconnection circuits" JW Bishop, Solar Cell (1988)
:doi:`10.1016/0379-6787(88)90059-2` No newline at end of file
:doi:`10.1016/0379-6787(88)90059-2`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here? It looks like nothing happened, but it shows as a change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an oversight on my part, I did not mean to alter that line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could link the references properly in line 20: by Jain and Kapoor _[1] _[2], and Hansen _[3].
We could also standardize the formatting of the references

Only if @FelixKoTU wants to, in my view.

This page really doesn't fit in a User Guide, it's more of detailed background we ought to have somewhere but didn't know where else to put it. My point is that we ought to consider rewriting this page and editing the references can be done in that revision.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if @FelixKoTU wants to, in my view.

This page really doesn't fit in a User Guide, it's more of detailed background we ought to have somewhere but didn't know where else to put it. My point is that we ought to consider rewriting this page and editing the references can be done in that revision.

Fair point!

@kandersolar
Copy link
Member

What changed here? It looks like nothing happened, but it shows as a change

I think it's whether the line ends in \n or not: https://github.com/FelixKoTU/pvlib-python/commit/5359efe3cd564807792cd99f6a80647928736859.patch

Doesn't really matter IMHO. Thanks @FelixKoTU!

@kandersolar kandersolar added this to the v0.11.2 milestone Nov 19, 2024
@kandersolar kandersolar merged commit fc8cfc0 into pvlib:main Nov 19, 2024
27 checks passed
@RDaxini
Copy link
Contributor

RDaxini commented Nov 19, 2024

Doesn't really matter IMHO

for sure no big deal I was kinda just curious 😅

@FelixKoTU FelixKoTU deleted the patch-1 branch November 19, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants