Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subprocess32 no longer needed #126

Merged
merged 1 commit into from
Sep 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
build
pytest
subprocess32
wheel
10 changes: 5 additions & 5 deletions pyfiglet/tests/test_cli.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import os
import subprocess

import pytest
import subprocess32


@pytest.fixture
Expand Down Expand Up @@ -30,14 +30,14 @@ def test_strip():
00:::::::::00
000000000
'''
result = subprocess32.run(command, shell=True, stdout=subprocess32.PIPE)
result = subprocess.run(command, shell=True, stdout=subprocess.PIPE)
assert result.stdout.decode() == expected
assert result.returncode == 0


def test_strip_strange_font(test_font_dir):
install_command = "pyfiglet -L %s/TEST_ONLY.flf " % test_font_dir
subprocess32.run(install_command, shell=True, check=True)
subprocess.run(install_command, shell=True, check=True)

command = "pyfiglet -f TEST_ONLY -s 0"
expected = '''\
Expand All @@ -51,7 +51,7 @@ def test_strip_strange_font(test_font_dir):

0000000000
'''
result = subprocess32.run(command, shell=True, stdout=subprocess32.PIPE)
result = subprocess.run(command, shell=True, stdout=subprocess.PIPE)
assert result.stdout.decode() == expected
assert result.returncode == 0

Expand Down Expand Up @@ -79,6 +79,6 @@ def test_normalize():
000000000

'''
result = subprocess32.run(command, shell=True, stdout=subprocess32.PIPE)
result = subprocess.run(command, shell=True, stdout=subprocess.PIPE)
assert result.stdout.decode() == expected
assert result.returncode == 0