Retrieve only user's projects, not every project on the server. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating causes the full public project list to be retrieved from the gitlab server. When working on gitlab.com, this can cause eclipse to hang during validation as it retrieves every public project in the system. Changed the call from getProjects() to getMembershipProjects(), which pulls only the projects that the user is a member of in some capacity - a small number of projects, rather than hundreds of thousands (millions?) of public repos available on gitlab.com.
Retrieve only projects user has access to during validation.
erwindl0
added a commit
to erwindl0/mylyn-gitlab
that referenced
this pull request
Jul 20, 2020
java-gitlab and jackson upgrade cfr pweingardt#59 and timols/java-gitlab-api#350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this given the discussion in #56 (and, iirc, other reports).
Caveat: I'm not entirely sure that the logic applies to all situations (though imo, it's the only sane approach to using gitlab.com). If you're on a private server.... is there a use case for retrieving projects you're not part of? If so, it probably needs some logic to pick which call to use, either based on if it's gitlab.com or not, or have a user checkbox or something.