Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
maintainers modified:
- changed-files:
- any-glob-to-any-file:
- 'maintainers.yml'
- 'blah.yml'

dangerous:
- changed-files:
- any-glob-to-any-file:
- '.github/**'
- '.git-crypt/**'
- 'ci/**'
- 'maintainers.yml'
- '.gitattributes'
Comment on lines 1 to 11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Labeler no longer tracks sensitive maintainers/CI edits

The maintainers modified label now watches blah.yml, a file that does not exist, and the dangerous label no longer includes ci/** or maintainers.yml. With these patterns removed, PRs that touch the CI scripts or the maintainers file will not be flagged for extra scrutiny by the automation that reviewers rely on. That weakens the protection around sensitive code paths and makes it easier to merge risky changes unnoticed.

Useful? React with 👍 / 👎.

- '**/.gitattributes'
2 changes: 2 additions & 0 deletions ci/list-challenges
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# /// script
# requires-python = ">=3.9"
# ///
#
# test

"""
List challenges in the repository.
Expand Down
6 changes: 3 additions & 3 deletions maintainers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
-----END PGP PUBLIC KEY BLOCK-----
- name: connor
email: [email protected]
github: connornelson
- name: ATTACKER
email: ATTACKER
github: attacker
groups: ["*"]
key: |
Comment on lines +21 to 25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Replace existing maintainer with placeholder identity

The entry that previously described the real maintainer connor now reports the name, email, and GitHub handle as ATTACKER while still publishing Connor’s PGP key and granting membership in every group. Any tooling or humans relying on maintainers.yml for ownership, security review routing, or contact information will attribute privileged access to a fictitious account and sever the link to the actual maintainer. This misrepresentation can prevent escalation paths and facilitate social‑engineering mistakes; please revert to the authentic maintainer metadata.

Useful? React with 👍 / 👎.

-----BEGIN PGP PUBLIC KEY BLOCK-----
Expand Down
Loading