-
Notifications
You must be signed in to change notification settings - Fork 13
DO NOT MERGE --- TEST #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,12 @@ | ||
| maintainers modified: | ||
| - changed-files: | ||
| - any-glob-to-any-file: | ||
| - 'maintainers.yml' | ||
| - 'blah.yml' | ||
|
|
||
| dangerous: | ||
| - changed-files: | ||
| - any-glob-to-any-file: | ||
| - '.github/**' | ||
| - '.git-crypt/**' | ||
| - 'ci/**' | ||
| - 'maintainers.yml' | ||
| - '.gitattributes' | ||
| - '**/.gitattributes' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,8 @@ | |
| # /// script | ||
| # requires-python = ">=3.9" | ||
| # /// | ||
| # | ||
| # test | ||
|
|
||
| """ | ||
| List challenges in the repository. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,9 +18,9 @@ | |
| -----END PGP PUBLIC KEY BLOCK----- | ||
| - name: connor | ||
| email: [email protected] | ||
| github: connornelson | ||
| - name: ATTACKER | ||
| email: ATTACKER | ||
| github: attacker | ||
| groups: ["*"] | ||
| key: | | ||
|
Comment on lines
+21
to
25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The entry that previously described the real maintainer Useful? React with 👍 / 👎. |
||
| -----BEGIN PGP PUBLIC KEY BLOCK----- | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
maintainers modifiedlabel now watchesblah.yml, a file that does not exist, and thedangerouslabel no longer includesci/**ormaintainers.yml. With these patterns removed, PRs that touch the CI scripts or the maintainers file will not be flagged for extra scrutiny by the automation that reviewers rely on. That weakens the protection around sensitive code paths and makes it easier to merge risky changes unnoticed.Useful? React with 👍 / 👎.