Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we store emojis by putting the emoji in the name, a description, and a reference to the dojo (if any) for which the emoji was earned. This causes some headaches:
This PR changes the design to:
name
field, from theSPECIAL_EMOJIS
global or from thedojo.data['award']['emoji']
of the respective dojoThe main effects have to do with dojos changing their awards:
SPECIAL_EMOJIS["missing"]
This PR maintains backwards compatibility with legacy emojis, though presumably we'll update the DB and remove that compatibility ASAP.
A further thing we might want to do is fix up emoji.category to key off the integer dojo ID, so that we can actually
join
onto it, but the current was is workable as well.