Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSRF Description #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix CSRF Description #31

wants to merge 2 commits into from

Conversation

ConnorNelson
Copy link
Member

@ConnorNelson ConnorNelson commented Dec 18, 2024

There are a number of issues here.

  • "Site" and "Origin" are used a little loosely. They both have very specific definitions that are different.
  • JavaScript not including cookies is because the default of fetch is to only include them for the same origin, but credentials="include" allows them to be sent (https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#including_credentials). Probably we should link to that documentation somewhere.
  • My understanding is that the Same Origin Policy really is less to do with sending requests and more to do with reading responses. For example, you can totally send a request, with cookies, using javascript. You just can't read the response (but the server still totally processed that request). Technically it's more complicated than that, only "simple" requests can be made. Cookie sending/not-sending is completely orthogonal (except that the default of the fetch API is to only include same-origin).

@ConnorNelson
Copy link
Member Author

I'm also really not sure what was meant by "the cookie is only accessible in HTTP headers", so I removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant