Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercepting Communication: src and dst checks #7

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

f4-u57
Copy link

@f4-u57 f4-u57 commented Oct 18, 2023

The packet levels are missing source and destination checks for MAC and IP addresses.

For example, in the first TCP level, there is no check for the dst IP, but the TCP handshake level does.

I think having random src or dst that work does not make sense in the context of networking.

Note that this module is currently active for 365.

@ConnorNelson
Copy link
Member

I assume you tested this?
Also, normally properties aren't verbs (check). I would just add something like user_host = self.network.hosts[0] or something to the beginning of the methods.

Did this effect student solutions in some way you noticed?

@f4-u57
Copy link
Author

f4-u57 commented Oct 18, 2023

Yes, I have tested it with my solution and made sure it actually checks the right things.

From what I noticed, this will affect students who are either not setting src/dst or just something random and also can causes misunderstanding of "blah src/dst worked last level but not this one" or wrong "src/dst don't matter" assumption.

@f4-u57 f4-u57 marked this pull request as draft January 7, 2024 03:54
@f4-u57 f4-u57 marked this pull request as ready for review January 7, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants