Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper console #90

Closed
Iapetus-11 opened this issue Dec 28, 2020 · 7 comments
Closed

Add proper console #90

Iapetus-11 opened this issue Dec 28, 2020 · 7 comments
Labels
Enhancement New feature, request, or thing stale Issue has been inactive for a while

Comments

@Iapetus-11
Copy link
Member

Console should have like two sections, horizontally split. The bottom-most one should be just one row/line and should contain a > and whatever the user is typing. The above section should contain output/logging information. If a user is typing, what they've typed should not be overwritten by any logging/output.

You can see any modern console, such as paper/bukkit/vanilla for how this looks/feels

@Iapetus-11 Iapetus-11 added the Enhancement New feature, request, or thing label Dec 28, 2020
@Iapetus-11
Copy link
Member Author

This looks very very promising: https://github.com/prompt-toolkit/python-prompt-toolkit
(special thanks to @ashwinvin for making me aware of it!)

@Iapetus-11 Iapetus-11 assigned Iapetus-11 and unassigned Sh-wayz and MFDGaming Jan 25, 2021
@Iapetus-11
Copy link
Member Author

After much experimentation I've run into an issue, the prompt is overwritten by new text. Yes I've tried using the patch_stdout() context manager, in multiple different places. If you can get it working, that'd be awesome.

@Iapetus-11 Iapetus-11 removed their assignment Jan 25, 2021
@Iapetus-11
Copy link
Member Author

Iapetus-11 commented Jan 25, 2021

In addition, it's also far slower than the normal print() statement so when debug mode is on, packet handling (and everything really) is slowed down significantly.

@Iapetus-11
Copy link
Member Author

Also the branch (90-console) could be deleted as not much has been done (and it's not even in a working condition)

@github-actions
Copy link

No activity detected, marking stale.

@github-actions github-actions bot added the stale Issue has been inactive for a while label Feb 25, 2021
@Iapetus-11
Copy link
Member Author

This has been taken over by #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request, or thing stale Issue has been inactive for a while
Projects
None yet
Development

No branches or pull requests

3 participants