Add maintainers-guidelines.md #1
Conversation
|
Thank you for your feedbacks @MartinThoma, but this is an early draft, far from being ready for review 😅 |
Co-authored-by: Martin Thoma <[email protected]>
|
I finally got back to this PR! Sorry for the time it took me to finish this 😅 I did not put as much in it as I initially planned, You have already initiated a section about Rules for py-pdf owners, You can merge it as it is or give me your feedback! |
|
Hi! No hurry there, just pinging potential reviewers: @MartinThoma, @MasterOdin, @mstamy2, @teschmitt |
| - id: trailing-whitespace | ||
| - id: mixed-line-ending | ||
| args: ['--fix=lf'] | ||
| exclude: "docs/make.bat" |
There was a problem hiding this comment.
I'm uncertain about this. Bat-files are for windows users and they use different line endings, but there is also git autocrlf: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings#global-settings-for-line-endings
However, we can just do it and see if anybody mentions issues.
| @@ -1,10 +1,10 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.11 | |||
There was a problem hiding this comment.
We should probably decide on a Python version + document that in the README.
|
@Lucas-C Thank you for the improvements 🤗 While I have some comments (see above), they are not blockers to merge it :-) |
Follows dicussions in sarnold/pdfrw#15 & py-pdf/fpdf2#752
Preview:
