Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom Stockfish builds for CI to test with different versions #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use custom Stockfish builds for CI to test with different versions #66

wants to merge 2 commits into from

Conversation

kieferro
Copy link
Member

@kieferro kieferro commented Sep 6, 2023 •
edited
Loading

This PR replaces the stockfish installation step with a cached custom build steps so that we can test with Stockfish 15.1 and Stockfish 16.

Things that aren't added yet, but that are made possible by this and that we could implement in the future:

  • Testing with a development version
  • Passing the specific version as a parameter to pytest and comparing it to the output from get_stockfish_full_version

@kieferro kieferro force-pushed the ci-stockfish-versions branch 6 times, most recently from 90ce5ea to e73f77f Compare September 6, 2023 14:59
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Coverage report

The coverage rate went from 96.5% to 96.5% ⬆️
The branch rate is 93%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@kieferro kieferro marked this pull request as ready for review September 6, 2023 15:03
@kieferro kieferro requested a review from johndoknjas September 6, 2023 15:04
@kieferro kieferro force-pushed the ci-stockfish-versions branch from e73f77f to 11e923c Compare September 6, 2023 15:11
@kieferro kieferro force-pushed the ci-stockfish-versions branch from 11e923c to da4e906 Compare September 6, 2023 16:04
@kieferro kieferro force-pushed the ci-stockfish-versions branch from da4e906 to a098190 Compare September 6, 2023 16:17
johndoknjas
johndoknjas approved these changes Aug 24, 2024
View reviewed changes
Copy link

@johndoknjas johndoknjas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very delayed review - looks good to me, this would be nice to have in order to test the most up to date versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndoknjas johndoknjas johndoknjas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieferro @johndoknjas