Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][FEA] Support Generalized Adjustment Criterion for Estimation plus Add Example Notebook #1297

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

nparent1
Copy link
Contributor

@nparent1 nparent1 commented Jan 19, 2025

Adds support for the generalized adjustment estimands at the estimation stage. The PR primarily does two things:

  • Abstracts the get_backdoor() method of the IdentifiedEstimand class to instead be a get_adjustment_set() method. Then if the identifier_method is specified as 'general_adjustment', the get_adjustment_set() method will return the general adjustment set (rather than explicitly a backdoor set). Then throughout the repo where get_backdoor_set() was called for estimation purposes, we instead call get_adjustment_set(). Note that because we have get_adjustment_set() default to the backdoor set, the overall behavior is the same as before, unless a user explicitly sets general_adjustment as the identifier_method.
  • Adds various tests and test utils. In particular, adds support for specifying explicit graphs in the estimation tests, for more specific tests of the general_adjustment criterion.

An example notebook is also added, dowhy_generalized_covariate_adjustment_estimation_example.ipynb

This is a follow-on PR to #1292

Issue Ref: #402

Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
Signed-off-by: Nicholas Parente <[email protected]>
@nparent1 nparent1 changed the title [FEA] Support Generalized Adjustment Criterion for Estimation plus Add Example Notebook [WIP][FEA] Support Generalized Adjustment Criterion for Estimation plus Add Example Notebook Jan 19, 2025
Signed-off-by: Nicholas Parente <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant