IMAGE: failing CI #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarified governance to be governance handbook, and corrected the link to point to the new handbook URL (was pointing to /governance)
Update README.md
lwasser
requested changes
Aug 22, 2024
| @@ -34,6 +34,9 @@ checks: | |||
| can be merged. The issues could be related to code style, formatting, tests, | |||
| or other criteria specified by the CI configuration. | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
@kierisi it's important that all of our documented are accessible. As such please add both an alt tag for accessibility and a caption. Here i think this is a caption, but it actually reads as an alt tag in the html rendered page.
You can either look at the myst markdown documentation for how to do this or look at how we add images in the packaging guide for guidance.
There was a problem hiding this comment.
great catch! fixed.
kierisi
added a commit
to kierisi/handbook
that referenced
this pull request
Aug 28, 2024
lwasser
pushed a commit
that referenced
this pull request
Aug 29, 2024
* Update README.md clarified governance to be governance handbook, and corrected the link to point to the new handbook URL (was pointing to /governance) * approve and run notification * checked out CI image from #87 * updated image
lwasser
approved these changes
Aug 29, 2024
re-added file
should fix merge conflict
|
@lwasser should be fixed! thanks to @tracykteal and @rich-iannone for the assist on this one! |
lwasser
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an image to the handbook showing what the red "X" looks like for a failing CI check. Resolves #82.