-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMAGE: failing CI #87
Conversation
clarified governance to be governance handbook, and corrected the link to point to the new handbook URL (was pointing to /governance)
Update README.md
@@ -34,6 +34,9 @@ checks: | |||
can be merged. The issues could be related to code style, formatting, tests, | |||
or other criteria specified by the CI configuration. | |||
|
|||
![When a CI check fails, you'll see a red 'X' next to the CI check that hasn't passed](/images/ci-images/contributor-ci-fail.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kierisi it's important that all of our documented are accessible. As such please add both an alt tag for accessibility and a caption. Here i think this is a caption, but it actually reads as an alt tag in the html rendered page.
You can either look at the myst markdown documentation for how to do this or look at how we add images in the packaging guide for guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Update README.md clarified governance to be governance handbook, and corrected the link to point to the new handbook URL (was pointing to /governance) * approve and run notification * checked out CI image from #87 * updated image
re-added file
should fix merge conflict
@lwasser should be fixed! thanks to @tracykteal and @rich-iannone for the assist on this one! |
Added an image to the handbook showing what the red "X" looks like for a failing CI check. Resolves #82.