Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ci run htmlproofer lst #51

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Fix: ci run htmlproofer lst #51

merged 8 commits into from
Apr 1, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Apr 1, 2024

This runs htmlproofer last. that way it can publish to gh pages if merged into main but we assume that if there are things we want to fix, we can do that in the pr.

this will avoid the issue of a new page "breaking" the build but we still want to publish because it is a new page that we want online and it is causing the error

@lwasser
Copy link
Member Author

lwasser commented Apr 1, 2024

merging this as htmlproofer is still angry but the build should work

@lwasser lwasser merged commit 39b3504 into pyOpenSci:main Apr 1, 2024
2 of 3 checks passed
@lwasser lwasser deleted the fix-ci branch April 1, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant