Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: sprint process to handbook #62

Merged
merged 10 commits into from
Jun 7, 2024
Merged

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented May 30, 2024

I am not sure that my idea for pr templates will work. i think we will need to go the -- remote person labels things. it gets added to the board once labeled via a workflow. remote person then moves it to the right column. if we do this it could just be easier for the remote person to do all of the labeling and project board adding manually because it would be on the side of the issue or pr and not too much more work to add the project board stuff there. ...


@lwasser lwasser marked this pull request as draft May 30, 2024 23:16

#### THIS LIKELY WON'T WORK Ensure issue and pull request templates are up to date

A challenge of a successful sprint is that there will be many issues and pull requests to triage after the sprint. To keep track of new issues and pr's, during an event, every pyOpenSci GitHub repository should have a sprint issue and pull request template. Adding this template only needs to be completed once, however
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go into scipy with a manual process and just see if automating adding to the board would help. i suspect it won't be that much more beneficial and more infra to maintain. If the pr template worked then it would make sense. but because i don't think the pr template will work (i remember fighting with this for stravalib) then manual labeling might be our best bet here. We could however have an issue template for sprints. that may or may not be useful .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we collet github usernames at the sprint start, the remote person would know who is contributing by their username making it even easier to identify sprint related activity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kierisi i see my THIS WONT WORK comment now 😆 it was not visible to me wednesday. but i do remember writing it now.

@lwasser lwasser requested a review from kierisi May 31, 2024 19:01
@lwasser lwasser marked this pull request as ready for review May 31, 2024 19:01
Copy link
Contributor

@kierisi kierisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in a bit of copy, but mostly small grammatical edits! I didn't flesh out any areas on the form//participant information collection, as that process is still WIP. let me know how else I can help with this!

community/events/intro.md Outdated Show resolved Hide resolved
community/events/intro.md Outdated Show resolved Hide resolved
community/events/intro.md Outdated Show resolved Hide resolved
community/events/intro.md Outdated Show resolved Hide resolved
community/events/intro.md Outdated Show resolved Hide resolved
community/events/sprints.md Outdated Show resolved Hide resolved
community/events/sprints.md Outdated Show resolved Hide resolved
community/events/sprints.md Outdated Show resolved Hide resolved
and community highlights.
- **GitHub**: Remind them to continue following and contributing to pyOpenSci
repositories on GitHub.
- Discourse?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading my mind! I have a note to talk about Discourse in our upcoming social media quarterly meeting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. how bout i just comment this out for the time being?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

community/events/sprints.md Outdated Show resolved Hide resolved
@lwasser lwasser added the enhancement New feature or request label Jun 7, 2024
@kierisi
Copy link
Contributor

kierisi commented Jun 7, 2024

@lwasser this looks good to me! the only (small, non-blocking) suggestion I have is to link from the TLDR in the sprints section to the expanded sections further in the page. that way if someone reads the TLDR and needs clarification, they can quickly navigate to the spot on the page.

@lwasser
Copy link
Member Author

lwasser commented Jun 7, 2024

awesome. i can do that @kierisi i'll do that now - push, and merge. and then we can flesh out the other sections later (related to contributor information and our database / gdpr etc!). thank you for the super helpful reviews today. i think it improved the content a lot!

@lwasser
Copy link
Member Author

lwasser commented Jun 7, 2024

yahoo! all green -- merging! this feels good. and it was a lot of work to document!

@lwasser lwasser merged commit 2b9d5dd into pyOpenSci:main Jun 7, 2024
3 checks passed
@lwasser lwasser deleted the events-sprints branch June 7, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants