feat(content): add PR checklist to the GitHub PR section #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarified governance to be governance handbook, and corrected the link to point to the new handbook URL (was pointing to /governance)
Update README.md
|
pre-commit.ci autofix |
lwasser
changed the title
lwasser
reviewed
Sep 17, 2024
lwasser
reviewed
Sep 17, 2024
| @@ -0,0 +1,74 @@ | |||
| # pyOpenSci uses Canva as a shared graphic platform | |||
There was a problem hiding this comment.
Is the Canva content in this PR intentional? There is a merge conflict with it (we merged #74 ) in this PR.
Please look closely at this pr and follow the checklist in this pr.
- make sure the files in this pr belong to this pr.
Please ping me to review again when this is fixed.
lwasser
requested changes
Sep 17, 2024
There was a problem hiding this comment.
@kierisi i haven't left a full set of comments. there is a merge conflict on this PR and also I don't know if you meant to add the canva page to this PR. can you please rebase this branch off of main and determine whether the canva page is intentional or not? I will then continue to review the content here. Feel free to address the few comments that i've already suggested and then ping me here to review again.
Co-authored-by: Leah Wasser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a PR checklist, as discussed with @lwasser. this list can be expanded upon, but represents a good initial set of checks for individuals to use when contributing to a pyopensci repository.