-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh: add sponsor page #309
base: main
Are you sure you want to change the base?
Conversation
_pages/support.md
Outdated
<div class="archive__item-body"> | ||
<h2 class="archive__item-title">Alfred P. Sloan Foundation</h2> | ||
<div class="archive__item-excerpt"> | ||
<p>The Alfred P. Sloan Foundation supports education and research related to science, technology, engineering, mathematics, and economics. Their mission is to “make the world a better place by advancing the frontiers of knowledge. We pledge to pursue that mission in ways that make the institutions of scientific endeavor more diverse, more equitable, and more inclusive to all.” You can learn more about the Sloan Foundation [on their About page](https://sloan.org/about). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im going to fix this locally. the reason why the url is not rendering is that you have an html block with a
tag and markdown within it. so it either needs to be markdown or html but not a mix of both (exceptions for divs with markdown="1" supports both).
but this specific layout is better suited to non html - a header yaml element for each of these blocks. so i'm going to redo this section and pull all of the text and image content up into the yaml and add an include :) the page will be cleaner that way!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thaaaank you! I knew it was a mess, and now that I know about getting to the rendered page through artifacts any new pages I make will (hopefully 😅 ) need less finessing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no problem. also i forgot to tell you. IF you can build the site locally, you can view an orphan page but just typing the url. so here it would be something like:
localhost:4000/sponsors.html
but yes the CI is here for us to make life easier so we don't always have to build. when i push changes i've made i'll comment on what i did and where just like i did for the volunteer page! the problem here is that this site is somewhat hacked together by me so it's not the most straight forward site to work with.
@willingc this one was put on hold after some discussions with the board. i don't want to close as it will get merged. However, it but it's lower priority right now as we launch the new learn section. And i have a few other things to figure out as well. Should we move it to draft for now? |
Thanks @lwasser. We can leave it as is. I added the "Do not merge" label. |
I've added the first pass at a sponsor page based on the copy outlined in our planning document, but the page will still need:
I named the page
support.html
– feel free to change!