Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: add sponsor page #309

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Enh: add sponsor page #309

wants to merge 10 commits into from

Conversation

kierisi
Copy link
Collaborator

@kierisi kierisi commented Dec 31, 2023

I've added the first pass at a sponsor page based on the copy outlined in our planning document, but the page will still need:

  • to be added to headers and sitemap
  • a logo for the company involved in in-kind donation
  • to link to the volunteer page under Get involved section once the volunteer page is published

I named the page support.html – feel free to change!


@lwasser lwasser marked this pull request as draft January 4, 2024 00:27
@lwasser lwasser added the reviews-welcome Please review this item! label Jan 4, 2024
@lwasser lwasser marked this pull request as ready for review January 4, 2024 00:29
<div class="archive__item-body">
<h2 class="archive__item-title">Alfred P. Sloan Foundation</h2>
<div class="archive__item-excerpt">
<p>The Alfred P. Sloan Foundation supports education and research related to science, technology, engineering, mathematics, and economics. Their mission is to “make the world a better place by advancing the frontiers of knowledge. We pledge to pursue that mission in ways that make the institutions of scientific endeavor more diverse, more equitable, and more inclusive to all.” You can learn more about the Sloan Foundation [on their About page](https://sloan.org/about).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im going to fix this locally. the reason why the url is not rendering is that you have an html block with a

tag and markdown within it. so it either needs to be markdown or html but not a mix of both (exceptions for divs with markdown="1" supports both).

but this specific layout is better suited to non html - a header yaml element for each of these blocks. so i'm going to redo this section and pull all of the text and image content up into the yaml and add an include :) the page will be cleaner that way!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thaaaank you! I knew it was a mess, and now that I know about getting to the rendered page through artifacts any new pages I make will (hopefully 😅 ) need less finessing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no problem. also i forgot to tell you. IF you can build the site locally, you can view an orphan page but just typing the url. so here it would be something like:

localhost:4000/sponsors.html

but yes the CI is here for us to make life easier so we don't always have to build. when i push changes i've made i'll comment on what i did and where just like i did for the volunteer page! the problem here is that this site is somewhat hacked together by me so it's not the most straight forward site to work with.

@lwasser lwasser changed the title [for review] first pass at sponsor page Enh: add sponsor page Jan 4, 2024
@kierisi kierisi requested a review from willingc as a code owner January 4, 2024 23:37
@willingc
Copy link
Collaborator

Let's loop back to this PR before PyCon. What's the priority on this one @lwasser @kierisi?

@willingc willingc added the feature:content New content, guide, or writing needed label Apr 10, 2024
@lwasser
Copy link
Member

lwasser commented Apr 10, 2024

@willingc this one was put on hold after some discussions with the board. i don't want to close as it will get merged. However, it but it's lower priority right now as we launch the new learn section. And i have a few other things to figure out as well.

Should we move it to draft for now?

@willingc willingc added the DO-NOT-MERGE A caution that a PR is not ready to be merged label Apr 12, 2024
@willingc
Copy link
Collaborator

Thanks @lwasser. We can leave it as is. I added the "Do not merge" label.

@lwasser lwasser removed the reviews-welcome Please review this item! label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE A caution that a PR is not ready to be merged feature:content New content, guide, or writing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants