Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup the precommit and codes #17

Merged
merged 14 commits into from
Aug 20, 2024

Conversation

Revathyvenugopal162
Copy link
Member

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 18, 2024

  • add ruff pre-commit hook
  • add linkcheck hooks

@@ -66,3 +64,43 @@ jobs:
name: book-html
path: |
./_build/html

- name: Deploy to gh pages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Revathyvenugopal162 this looks good. I think we want to use the new deploy to GitHub pages that we are using in our website repo here

Are you open to modifying this to use deploy to GH pages rather than the peaceiris action instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser ,sure, i can revert to that change.

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this to be merged but do request we use the deploy action rather than peace iris if it is true that - that method is now preferred by GitHub. that is what i was told!! Thank yoy so much for this!

@lwasser
Copy link
Member

lwasser commented Aug 20, 2024

awesome! merging! thank you again!

@lwasser lwasser merged commit 8b2cb17 into pyOpenSci:main Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants