Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: new page overviewing CI #165

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add: new page overviewing CI #165

wants to merge 6 commits into from

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Jan 16, 2024

This pr is the final piece of content from the now closed pr #104 that was opened in september. it contains 2 short pages

  1. describing CI
  2. overviewing code coverage.

because it's been so long i plan to review / edit prior to making this reviewable.


@@ -97,7 +97,7 @@
"image_light": "logo-light-mode.png",
"alt_text": "pyOpenSci Python Package Guide. The pyOpenSci logo is a purple flower with pyOpenSci under it. The o in open sci is the center of the flower",
},
"header_links_before_dropdown": 4,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes space for a CI&data section in our navigation.

@willingc
Copy link
Collaborator

@lwasser Should we close this draft? Or do you want to leave open.

@lwasser
Copy link
Member Author

lwasser commented Mar 21, 2024

@willingc i think we need to keep this one open. its content that i have yet to finish. so maybe a help-wanted tag is warranted. this page isn't high priority now but i can try to put it in my task list as a chip away at it task.

@lwasser
Copy link
Member Author

lwasser commented Mar 21, 2024

tasks

  • rebase against main
  • revisit content and figure out what section it belongs in
  • edit
  • send through community review

@lwasser lwasser changed the title Ci Add: new page overviewing CI Mar 21, 2024
lwasser and others added 6 commits April 3, 2024 10:36
ENH: fixes from Jonny's review

Fix: review edits from Jonny p2

Fix: typos and cleanup

Fix: add example to tests ci page
Co-authored-by: Nick Murphy <[email protected]>

Update ci-tests-data/ci.md

Co-authored-by: Nick Murphy <[email protected]>

Update ci-tests-data/ci.md

Co-authored-by: Nick Murphy <[email protected]>

Update ci-tests-data/ci.md

Co-authored-by: Nick Murphy <[email protected]>

Update ci-tests-data/ci.md

Co-authored-by: Nick Murphy <[email protected]>

Update ci-tests-data/ci.md

Co-authored-by: Nick Murphy <[email protected]>

Update ci-tests-data/code-cov.md

Co-authored-by: Nick Murphy <[email protected]>

Fix: edits from @namurphy to run tests page

Co-authored-by: Nick Murphy <[email protected]>

Update ci-tests-data/run-tests.md

Co-authored-by: Nick Murphy <[email protected]>
Co-authored-by: Trevor James Smith <[email protected]>

Fix: edit from trevor

Co-authored-by: Trevor James Smith <[email protected]>

Fix: edit from trevor

Co-authored-by: Trevor James Smith <[email protected]>

Fix: edits from Trevor

Co-authored-by: Trevor James Smith <[email protected]>

Fix: edits from Nick

Co-authored-by: Nick Murphy <[email protected]>

Packaging image

Fix: remove unused block

Fix

Update ci-tests-data/tests-ci.md

Co-authored-by: Trevor James Smith <[email protected]>
Co-authored-by: Carol Willing <[email protected]>

Update ci-tests-data/ci.md

Co-authored-by: Carol Willing <[email protected]>

Update ci-tests-data/ci.md

Co-authored-by: Carol Willing <[email protected]>

Fix: other edits from review'
Fix: force to main

Fix: main

Fix: update for final page review

Fix: remove dated image
@lwasser lwasser marked this pull request as ready for review April 3, 2024 16:37
@willingc willingc added enhancement-feature something new to add to our guide draft Draft PRs - do not merge labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Draft PRs - do not merge enhancement-feature something new to add to our guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants