Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate tutorials page [partial/wip] #342

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Conversation

ncclementi
Copy link
Contributor

@ncclementi ncclementi commented Jul 14, 2024

This is the beginning of the translation of the tutorials page.

So far there is a partial translation of the tutorials/add-license-coc.html page.

xref: #313

@willingc willingc added the translations Translation and localization of content label Aug 1, 2024
@flpm flpm added the lang-ES Spanish Translation label Aug 11, 2024
Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ncclementi for helping with the translation!

I made a few minor change suggestions.

Also, looks like there is an issue with the CI unrelated with the translation, because a link in the guide has changed, I made PR#383 to fix the link, so when that is merged there should be no error.

locales/es/LC_MESSAGES/tutorials.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/tutorials.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/tutorials.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/tutorials.po Outdated Show resolved Hide resolved
locales/es/LC_MESSAGES/tutorials.po Outdated Show resolved Hide resolved
ncclementi and others added 5 commits August 20, 2024 17:57
Co-authored-by: Felipe Moreno <[email protected]>
Co-authored-by: Felipe Moreno <[email protected]>
Co-authored-by: Felipe Moreno <[email protected]>
Co-authored-by: Felipe Moreno <[email protected]>
Co-authored-by: Felipe Moreno <[email protected]>
Copy link
Member

@flpm flpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flpm
Copy link
Member

flpm commented Aug 22, 2024

There is an issue with the footnotes at /tutorials/add-license-coc.md:30:

WARNING: inconsistent footnote references in translated message. original: ['[^mit]', '[^bsd3]'], translated: []

I will merge the PR and create an issue to track, since I don't think is related to the translation

@flpm flpm merged commit fc163f0 into pyOpenSci:main Aug 22, 2024
4 checks passed
@flpm
Copy link
Member

flpm commented Aug 22, 2024

Thanks again for helping with the translation!

@tkoyama010
Copy link
Member

@all-contributors please add @ncclementi for translation

Copy link
Contributor

@tkoyama010

I've put up a pull request to add @ncclementi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-ES Spanish Translation translations Translation and localization of content
Projects
Development

Successfully merging this pull request may close these issues.

4 participants