-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change update translation sessions in nox #398
base: main
Are you sure you want to change the base?
Conversation
minor thing: i wonder if we can pick one term to refer to a translation or language? currently we have something like this
i don't have a strong preference between four sessions vs two sessions s.t. with no arguments they build/update all languages but with an argument only update a single language (or only the released langs, etc), but i think in either case it would be good to pick either language or translation to refer to them |
Good point, that makes sense, maybe "languages" is more semantically correct? |
I did a bit of reorganization of the nox sessions related to translations, to harmonize the names. I also simplified it a bit, to remove the internal build to release variable. Here is the proposed setup:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it - good with me :)
as an aside, since i'm not asking you to fix nox in this PR - the only thing i wish is that nox had a bit of a better way of sharing venvs, because each of these will make their own venv which makes things big and slow. making each of the sessions independent (rather than using notify
) i think makes them tidier and easier to read than notify and posargs, which i like tho, so it's an improvement imo :)
Thanks @flpm ! |
Wondering if we can merge this? i gave approval but i guess i don't have the right permissions or role or w/e to overcome the merge block. |
What was done
Following the discussion in PR #397, this PR makes the following changes:
update-translations
session to only update translation files for languages inRELEASE_LANGUAGES
.update-langugage
that can be used to update the translation files for a specific language.This PR also fixes a small syntax issue in the
documentation.po
file for the Spanish translation (missing quote).How to test
Run
nox -s update-translations
and confirm in the output that no languages are updatedRun
nox -s update-language -- es
and verify that the .po files for the Spanish translation are updated