Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix qt main window composition #686

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

fixes #685 by making _qwidget point to the actual MainWindow object (rather than the central widget) in the Qt MainWindow implementation

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (bf9f663) to head (94b1a0e).

Files with missing lines Patch % Lines
src/magicgui/backends/_qtpy/widgets.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   88.85%   88.86%   +0.01%     
==========================================
  Files          39       39              
  Lines        4756     4761       +5     
==========================================
+ Hits         4226     4231       +5     
  Misses        530      530              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MainWindow and Container exhibit assymetric behavior on .close()
1 participant