Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: proof of principle bringing microvis model to ndv #113

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

this is just a playground/draft PR, that brings in much of the model and vispy implementation from tlambert03/microvis

will follow up with an explanation. x.py has a basic example

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 1.02041% with 1067 lines in your changes missing coverage. Please review.

Project coverage is 62.22%. Comparing base (796588a) to head (4de6bfe).

Files with missing lines Patch % Lines
src/ndv/models/_scene/_vis_model.py 0.00% 126 Missing ⚠️
src/ndv/models/_scene/_transform.py 0.00% 118 Missing ⚠️
src/ndv/models/_scene/nodes/node.py 0.00% 96 Missing ⚠️
src/ndv/models/_scene/view.py 0.00% 66 Missing ⚠️
src/ndv/models/_sequence.py 0.00% 65 Missing ⚠️
src/ndv/models/_scene/canvas.py 0.00% 60 Missing ⚠️
src/ndv/views/_scene/vispy/_view.py 0.00% 46 Missing ⚠️
src/ndv/views/_scene/pygfx/_view.py 0.00% 44 Missing ⚠️
src/ndv/views/_scene/pygfx/_camera.py 0.00% 41 Missing ⚠️
src/ndv/views/_scene/pygfx/_canvas.py 0.00% 40 Missing ⚠️
... and 20 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #113       +/-   ##
===========================================
- Coverage   75.69%   62.22%   -13.48%     
===========================================
  Files          49       78       +29     
  Lines        4897     5975     +1078     
===========================================
+ Hits         3707     3718       +11     
- Misses       1190     2257     +1067     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant