Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip ubuntu-vispy-pyside-3.12 #137

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

tlambert03
Copy link
Member

this particular combination always fails on CI.

@tlambert03 tlambert03 added the tests tests and CI label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.81%. Comparing base (5b404bf) to head (0ea22af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   76.81%   76.81%           
=======================================
  Files          49       49           
  Lines        4930     4930           
=======================================
  Hits         3787     3787           
  Misses       1143     1143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gselzer
Copy link
Collaborator

gselzer commented Feb 12, 2025

Are you sure that this one always segfaults? Most of my CI jobs on #114 (which are up-to-date with main) show that job passing (example)

@tlambert03
Copy link
Member Author

It's definitely not the only one, and it's not always seg faulting either . I thought it was the main culprit when I was doing my testing? But no, not sure

@tlambert03 tlambert03 merged commit c3cf013 into pyapp-kit:main Feb 13, 2025
51 checks passed
@tlambert03 tlambert03 deleted the skip-ubuntu-pyside-vispy branch February 13, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants